Skip to content

[#9407]Enable Firestore data bundle to support empty array #9467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cherylEnkidu merged 3 commits into from
Mar 23, 2022
Merged

[#9407]Enable Firestore data bundle to support empty array #9467

cherylEnkidu merged 3 commits into from
Mar 23, 2022

Conversation

@cherylEnkidu
Copy link
Contributor

@cherylEnkidu cherylEnkidu commented Mar 16, 2022

#no-changelog
[Closes #9407]

Unicode character wasn't the reason why decode failed. When user's bundle text file contains empty array, it doesn't fulfill the RequireArray condition in BundleSerializer. This PR changes the requirements to Optional which can better support empty array decoding.

@google-oss-bot
Copy link

google-oss-bot commented Mar 16, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 86.61% (676d17d) to 86.64% (80dc327) by +0.03%.

    FilenameBase (676d17d)Merge (80dc327)Diff
    bundle_serializer.cc91.84%90.42%-1.42%
    ordered_code.cc93.41%94.15%+0.73%
    serializer.cc87.16%87.70%+0.54%
    watch_stream.cc90.70%95.35%+4.65%
    write_stream.cc90.14%94.37%+4.23%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7HTXhjnUpz.html

@cherylEnkidu cherylEnkidu requested a review from wu-hui March 16, 2022 21:08
@wu-hui wu-hui self-assigned this Mar 17, 2022
@cherylEnkidu cherylEnkidu self-assigned this Mar 17, 2022
wu-hui
wu-hui reviewed Mar 18, 2022
View reviewed changes
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/emptyArray branch from eb88337 to 5013faa Compare March 21, 2022 17:26
@google-oss-bot
Copy link

google-oss-bot commented Mar 21, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (676d17d)Merge (80dc327)Diff
    CocoaPods5.05 MB5.05 MB-8 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Y3Mdc0r10h.html

@cherylEnkidu cherylEnkidu force-pushed the cheryllin/emptyArray branch from 5013faa to 8096623 Compare March 21, 2022 23:27
wu-hui
wu-hui approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please address the comments.

@wu-hui wu-hui removed their assignment Mar 22, 2022
@cherylEnkidu cherylEnkidu force-pushed the cheryllin/emptyArray branch from 8096623 to a0bb652 Compare March 22, 2022 19:10
@cherylEnkidu cherylEnkidu merged commit 6911d52 into master Mar 23, 2022
@cherylEnkidu cherylEnkidu deleted the cheryllin/emptyArray branch March 23, 2022 15:23
@firebase firebase locked and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@cherylEnkidu cherylEnkidu

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Firestore Data Bundles doesn't support empty Array and empty Map

3 participants

@cherylEnkidu @google-oss-bot @wu-hui