-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replay FirestoreEncoder changes #3849
Conversation
From swiftlang/swift@3391b74 pulled with the tag swift-DEVELOPMENT-SNAPSHOT-2019-09-04-a.
FirestoreEncoder/Decoder and Timestamp/GeoPoint codable support.
* working serverTimestamp * working FieldValue. Still need: document ref and ability to Eq of FieldValue * DocumentReference implemented and testing works * clean up header search path * improving FieldValue enum comments * run through formatting * addressing comments * formatted with swiftformat 0.35.7 * add missing bool->BOOL change * undo unintended swift version change * remove unwanted proj file change
…egration tests (#3261) * Convinience api for codables * Integration Tests * ExplicitNull implementation
* Commit with failed optional test case. * Integration Test and cleanup * swiftformat * better doc formatting * addressing comments * rename to SelfDocumentID * Addressing Comments * fix comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
The other commits are from @wu-hui's old github handle. |
Replay the changes made in the old non-conforming location and migrate
to using the FirestoreEncoder from the new location.
Changes:
f149795 (Marek Gilbert, 2 hours ago)
Migrate to encoders in third_party/FirestoreEncoder
330ef74 (wu-hui, 7 days ago)
Add @documentid equivalent to Swift Codable (#3762)
Commit with failed optional test case.
Integration Test and cleanup
swiftformat
better doc formatting
addressing comments
rename to SelfDocumentID
Addressing Comments
fix comment
e39eb40 (Hui-Wu, 3 months ago)
Allow firestore api to work with Codable objects + ExplicitNull +
Integration tests (#3261)
Convinience api for codables
Integration Tests
ExplicitNull implementation
14c8d1b (Morgan Chen, 3 months ago)
Fix token fetch not invoking callback for unchanged token (#3251)
78b1828 (Hui-Wu, 3 months ago)
FieldValue and DocumentReference codable support. (#3231)
working serverTimestamp
working FieldValue. Still need: document ref and ability to Eq of
FieldValue
DocumentReference implemented and testing works
clean up header search path
improving FieldValue enum comments
run through formatting
addressing comments
formatted with swiftformat 0.35.7
add missing bool->BOOL change
undo unintended swift version change
remove unwanted proj file change
8ecec2b (Hui-Wu, 3 months ago)
Firestore swift Codable support (#3198)
FirestoreEncoder/Decoder and Timestamp/GeoPoint codable support.
30e4937 (Marek Gilbert, 2 hours ago)
Rename JSONEncoder; prep for split
8285f20 (Marek Gilbert, 7 days ago)
Pristine copy of JSONEncoder.swift
From
swiftlang/swift@3391b74
pulled with the tag swift-DEVELOPMENT-SNAPSHOT-2019-09-04-a.