Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FIAM Travic CI issues #2380

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Fix FIAM Travic CI issues #2380

merged 3 commits into from
Feb 12, 2019

Conversation

christibbs
Copy link
Contributor

Fix imports to potentially address Travis CI issues.

  • Remove duplicate imports of FIRInAppMessagingRendering.h
  • Use global import of FIRInAppMessagingRendering.h

@christibbs christibbs changed the title Fiam travis issues Fix FIAM Travic CI issues Feb 12, 2019
morganchen12
morganchen12 approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christibbs christibbs merged commit c27c67a into master Feb 12, 2019
bstpierr added a commit that referenced this pull request Feb 19, 2019
@bstpierr
Merge branch 'master' into bs-gullogger
e393eb0 
* master:
  E2e tests split (#2401)
  Split auth api tests into multiple cases (#2399)
  Add a ToString function to create human-readable debug descriptions (#2384)
  Split Auth unit tests (#2396)
  Create umbrella header for FIAM (#2392)
  Deprecate setMinimumSessionInterval (#2305)
  Forbid queries endAt an uncommitted server timestamp. (#2382)
  update changelog for release (#2383)
  Fix FIAM Travic CI issues (#2380)
  Remove swift sample for Auth (#2371)
  C++ migration: port `FSTTransaction` (#2362)
  Fix a bug where unlinking emailpassword doesn’t remove provider data (#2370)
  Fix a bug where sign in with Game Center doesn’t return additional user info (#2368)
  Firebase In-app messaging callbacks (#2354)
  Fix a bug where sign in with email link always return isNewUser as false (#2363)
  C++ migration: eliminate `FSTRemoteStore` (#2338)
@paulb777 paulb777 deleted the fiam-travis-issues branch October 2, 2019 19:19
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christibbs @morganchen12 @googlebot