Continue Firestore Codable 3 #2229
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright 2018 Google | ||
paulb777 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| enum FirestoreDecodingError: Error { | ||
|
There was a problem hiding this comment. These need comments if they're going to be public. We can ignore this for now though. |
||
| case decodingIsNotSupported | ||
| } | ||
|
|
||
| enum FirestoreEncodingError: Error { | ||
| case encodingIsNotSupported | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Copyright 2018 Google | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import FirebaseFirestore | ||
|
|
||
| /** | ||
| * A protocol describing the encodable properties of a DocumentReference. | ||
| * | ||
| * Note: this protocol exists as a workaround for the Swift compiler: if the DocumentReference class | ||
| * was extended directly to conform to Codable, the methods implementing the protocol would be need | ||
| * to be marked required but that can't be done in an extension. Declaring the extension on the | ||
| * protocol sidesteps this issue. | ||
| */ | ||
| fileprivate protocol CodableDocumentReference: Codable {} | ||
|
|
||
| extension CodableDocumentReference { | ||
| public init(from decoder: Decoder) throws { | ||
| throw FirestoreDecodingError.decodingIsNotSupported | ||
| } | ||
|
|
||
| public func encode(to encoder: Encoder) throws { | ||
| throw FirestoreEncodingError.encodingIsNotSupported | ||
| } | ||
| } | ||
|
|
||
| extension DocumentReference: CodableDocumentReference {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * Copyright 2018 Google | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import FirebaseFirestore | ||
|
|
||
| /** | ||
| * A protocol describing the encodable properties of a FirebaseFirestore. | ||
| * | ||
| * Note: this protocol exists as a workaround for the Swift compiler: if the FieldValue class | ||
| * was extended directly to conform to Codable, the methods implementing the protocol would be need | ||
| * to be marked required but that can't be done in an extension. Declaring the extension on the | ||
| * protocol sidesteps this issue. | ||
| */ | ||
| fileprivate protocol CodableFieldValue: Encodable {} | ||
ryanwilson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| extension CodableFieldValue { | ||
| public func encode(to encoder: Encoder) throws { | ||
| throw FirestoreEncodingError.encodingIsNotSupported | ||
| } | ||
| } | ||
paulb777 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| extension FieldValue: CodableFieldValue {} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright 2018 Google | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import FirebaseFirestore | ||
|
|
||
| /** | ||
| * A protocol describing the encodable properties of a DocumentSnapshot. | ||
| * | ||
| * Note: this protocol exists as a workaround for the Swift compiler: if the Timestamp class | ||
| * was extended directly to conform to Codable, the methods implementing the protocol would be need | ||
| * to be marked required but that can't be done in an extension. Declaring the extension on the | ||
| * protocol sidesteps this issue. | ||
| */ | ||
| public protocol CodableTimestamp: Codable { | ||
| init(date: Date) | ||
| func dateValue() -> Date | ||
paulb777 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| extension CodableTimestamp { | ||
| var date: Date { return dateValue() } | ||
| public init(from decoder: Decoder) throws { | ||
| let container = try decoder.singleValueContainer() | ||
| self.init(date: try container.decode(Date.self)) | ||
paulb777 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| public func encode(to encoder: Encoder) throws { | ||
| var container = encoder.singleValueContainer() | ||
| try container.encode(dateValue()) | ||
| } | ||
| } | ||
|
|
||
| extension Timestamp: CodableTimestamp {} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be required and is likely harmful. We don't want any C++ when compiling Swift.
Same for the Release configuration below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's what happens without the abseil include building the swift tests: