Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue Firestore Codable #2178

Closed
wants to merge 46 commits into from
Closed

Continue Firestore Codable #2178

wants to merge 46 commits into from

Conversation

paulb777
Copy link
Member

Pick up from where #838 left off, starting by merging it with current master

wilhuff and others added 30 commits February 19, 2018 16:27
@wilhuff
Add Firestore_SwiftTests_iOS target to Xcode
3598b86
@wilhuff
Clean up generated Firestore_SwiftTests_iOS test target
959cc57 
  * Move Example/Firestore_SwiftTests_iOS to Swift/Tests
  * Delete generated test case
  * Update Info.plist location to match
@wilhuff
Add FirebaseFirestoreSwift podspec
ad832a1
@wilhuff
Add Firestore_SwiftTests_iOS to the Podfile
24daa10 
Also corresponding xcodeproj changes
@wilhuff
Add CodableGeoPoint
6fc2dd4
@wilhuff
Move Firestore_SwiftTests_iOS to the top-level of the Podfile
b5d72b0
@wilhuff
Add CodableGeoPointTests to the project
c719b85
Add FirebaseEncoder
448bbbf
Update Encoder
557883e
Fix typo
86bbf4b
Make the extension available only from swift 4
cb7e0a8
Add FirestoreDecoder
6303624
Make all the types in Encoder as available from swift 4
f20e338
Add extension to document snapshot
9f13acf
Refactor to private Decoder and Encoder
a423896
Add internal type Firestore.Decoder
dcc4b4a
Add internal Firestore.Encoder type
493a157
Move to proper sub folder
c9b35c7
Confirm DocumentReference to Codable
05e20fd
Confirm FieldValue to Encodable protocol
735331d
Fix copyright
889f29a
Merge master into codable-firestore
4fed07f
Refactor to requireKey and requireValue private methods
ccdd0fc
Fix field value comment
93f7430
Fix names of the files
abe43e4
Move errors to separate file
073901a
Refactor to use expectNotAtEnd
a62364d
Fix using internal type mismatch method
f19ea99
Refactor to require value private function
3ea3eba
Refactor to private methods to require values
d23c201
@firebase firebase deleted a comment from googlebot Jan 3, 2019
@paulb777 paulb777 added cla: yes and removed cla: no labels Jan 3, 2019
@googlebot googlebot added cla: no and removed cla: yes labels Jan 3, 2019
@paulb777 paulb777 added cla: yes and removed cla: no labels Jan 3, 2019
@firebase firebase deleted a comment from googlebot Jan 3, 2019
@firebase firebase deleted a comment from googlebot Jan 3, 2019
@googlebot googlebot added cla: no and removed cla: yes labels Jan 3, 2019
@paulb777 paulb777 added cla: yes and removed cla: no labels Jan 3, 2019
@firebase firebase deleted a comment from googlebot Jan 3, 2019
@firebase firebase deleted a comment from googlebot Jan 3, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Jan 3, 2019
paulb777 added a commit that referenced this pull request Jan 3, 2019
@paulb777
Squash #2178 to continue Firestore Codable (#2228)
1743eb2
@paulb777 paulb777 mentioned this pull request Jan 3, 2019
Closed
@paulb777
Copy link
Member Author

paulb777 commented Jan 3, 2019

Squashed into and continued at #2229. Please continue reviews there.

@paulb777 paulb777 closed this Jan 3, 2019
This was referenced Mar 26, 2019
Closed
Closed
@paulb777 paulb777 deleted the pb-codable branch October 2, 2019 19:19
@firebase firebase locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @googlebot @wilhuff