Skip to content

Comments

[Crashlytics] Add attribute for Info.plist to manually force back to mach exception default behavior#15735

Merged
themiswang merged 1 commit intomainfrom
machFlag
Jan 20, 2026
Merged

[Crashlytics] Add attribute for Info.plist to manually force back to mach exception default behavior#15735
themiswang merged 1 commit intomainfrom
machFlag

Conversation

@themiswang
Copy link
Contributor

To preventing any unexpected issue for the upcoming release, add an attribute which user can insert into Info.plist to user can force switch back the original behavior

Revert this PR once release goes stable

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@themiswang themiswang requested a review from mrober January 19, 2026 19:55
@themiswang themiswang marked this pull request as ready for review January 19, 2026 20:04
@themiswang
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a temporary feature allowing users to revert to the EXCEPTION_DEFAULT Mach exception behavior on macOS 12+ via an Info.plist flag. This serves as a safeguard for an upcoming release. The implementation is well-contained, correctly passing the new setting from the Info.plist to the Mach exception handler configuration. My review includes minor suggestions to correct typos and enhance test coverage for this new functionality.

@themiswang themiswang changed the title Add attribute for Info.plist to manually force back to mach exception default behavior [Crashlytics] Add attribute for Info.plist to manually force back to mach exception default behavior Jan 19, 2026
@themiswang themiswang requested a review from ncooke3 January 19, 2026 20:39
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@themiswang themiswang merged commit a384e62 into main Jan 20, 2026
51 of 52 checks passed
@themiswang themiswang deleted the machFlag branch January 20, 2026 16:26
JesusRojass pushed a commit to JesusRojass/firebase-ios-sdk that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants