[Crashlytics] Add attribute for Info.plist to manually force back to mach exception default behavior#15735
[Crashlytics] Add attribute for Info.plist to manually force back to mach exception default behavior#15735themiswang merged 1 commit intomainfrom
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a temporary feature allowing users to revert to the EXCEPTION_DEFAULT Mach exception behavior on macOS 12+ via an Info.plist flag. This serves as a safeguard for an upcoming release. The implementation is well-contained, correctly passing the new setting from the Info.plist to the Mach exception handler configuration. My review includes minor suggestions to correct typos and enhance test coverage for this new functionality.
… default behavior
…mach exception default behavior (firebase#15735)
To preventing any unexpected issue for the upcoming release, add an attribute which user can insert into Info.plist to user can force switch back the original behavior
Revert this PR once release goes stable
#no-changelog