Skip to content

Comments

[AI] Add an implicit caching unit test#15727

Merged
paulb777 merged 2 commits intomainfrom
pb-imp-cache-unit-test
Jan 16, 2026
Merged

[AI] Add an implicit caching unit test#15727
paulb777 merged 2 commits intomainfrom
pb-imp-cache-unit-test

Conversation

@paulb777
Copy link
Member

Add a new unit test based on the new mock test data added in FirebaseExtended/vertexai-sdk-test-data#57

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@paulb777
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new unit test for implicit caching functionality. The test is well-structured and uses mock data to verify the parsing of the API response, including caching-related fields. I've added a couple of minor suggestions to make the test assertions even more comprehensive and readable. Overall, this is a good addition to the test suite.

@paulb777 paulb777 requested review from andrewheard and rlazo January 16, 2026 00:01
@paulb777
Copy link
Member Author

Integration test failure addressed by #15730

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulb777 paulb777 merged commit 09dcec1 into main Jan 16, 2026
65 of 67 checks passed
@paulb777 paulb777 deleted the pb-imp-cache-unit-test branch January 16, 2026 16:07
JesusRojass pushed a commit to JesusRojass/firebase-ios-sdk that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants