[AI] Add an implicit caching unit test#15727
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a new unit test for implicit caching functionality. The test is well-structured and uses mock data to verify the parsing of the API response, including caching-related fields. I've added a couple of minor suggestions to make the test assertions even more comprehensive and readable. Overall, this is a good addition to the test suite.
FirebaseAI/Tests/Unit/GenerativeModelVertexAICachingTests.swift
Outdated
Show resolved
Hide resolved
|
Integration test failure addressed by #15730 |
Add a new unit test based on the new mock test data added in FirebaseExtended/vertexai-sdk-test-data#57
#no-changelog