fix: flaky FIRMessagingPendingTopicsListTest.m

[ncooke3]

This pull request aims to fix a flaky test in FIRMessagingPendingTopicsListTest.m by introducing a configurable dispatch queue for topic operations. This allows tests to use a specific queue, improving determinism. The changes involve adding a new internal designated initializer to FIRMessagingPendingTopicsList that accepts a dispatch_queue_t, and updating asynchronous operations to use this queue. The tests are then modified to use this new initializer with a high-priority queue.

Same approach taken in Crashlytics: #15623

Fix #15715

#no-changelog

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

[ncooke3]

/gemini review

[gemini-code-assist]

Code Review

This pull request aims to fix a flaky test in FIRMessagingPendingTopicsListTest.m by introducing a configurable dispatch queue for topic operations. This allows tests to use a specific queue, improving determinism. The changes involve adding a new internal designated initializer to FIRMessagingPendingTopicsList that accepts a dispatch_queue_t, and updating asynchronous operations to use this queue. The tests are then modified to use this new initializer with a high-priority queue. The changes are logical and well-targeted to solve the flakiness issue. My feedback includes a suggestion to explicitly mark the new initializer as a designated initializer for better code correctness and maintainability.