Skip to content

Add unit test for FirebaseOptions copying#15722

Merged
paulb777 merged 1 commit intomainfrom
firebase-core-options-copy-test-12823941451683876584
Jan 15, 2026
Merged

Add unit test for FirebaseOptions copying#15722
paulb777 merged 1 commit intomainfrom
firebase-core-options-copy-test-12823941451683876584

Conversation

@google-labs-jules
Copy link
Contributor

Added testCopying to FirebaseCore/Tests/SwiftUnit/FirebaseOptionsTests.swift. This test ensures that FirebaseOptions instances are copied correctly, covering both dictionary-backed properties and the appGroupID property which requires manual copying logic. This prevents regressions where new properties might be missed in the copyWithZone implementation.


PR created automatically by Jules for task 12823941451683876584 started by @ryanwilson

This adds a unit test to verify that `FirebaseOptions` correctly implements `NSCopying`, ensuring all properties (including those manually handled like `appGroupID`) are copied and that the copy is independent of the original.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@danger-firebase-ios
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 marked this pull request as ready for review January 15, 2026 15:23
@paulb777 paulb777 requested a review from a team as a code owner January 15, 2026 15:23
@paulb777 paulb777 requested a review from ncooke3 January 15, 2026 15:24
@paulb777 paulb777 merged commit 91a6166 into main Jan 15, 2026
53 checks passed
@paulb777 paulb777 deleted the firebase-core-options-copy-test-12823941451683876584 branch January 15, 2026 15:47
JesusRojass pushed a commit to JesusRojass/firebase-ios-sdk that referenced this pull request Jan 22, 2026
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants