Skip to content

[AI] Restore URL Context integration test#15707

Merged
paulb777 merged 2 commits intomainfrom
pb-restore-url-context
Jan 14, 2026
Merged

[AI] Restore URL Context integration test#15707
paulb777 merged 2 commits intomainfrom
pb-restore-url-context

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Jan 13, 2026

Restore previously flaky URL Context integration test for the Developer API.

The test failures seem unrelated and also occur in the nightly #15701.

Fix #15385

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@paulb777
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restores a previously flaky integration test for the URL Context feature by removing the withKnownIssue wrapper. This indicates that the underlying flakiness has been resolved. The change is straightforward and correct, re-enabling the test as intended. I've added a minor suggestion to improve code readability by grouping related assertions.

@firebase firebase deleted a comment from danger-firebase-ios bot Jan 13, 2026
…grationTests.swift

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@paulb777 paulb777 requested a review from andrewheard January 13, 2026 15:47
@paulb777 paulb777 closed this Jan 14, 2026
@paulb777 paulb777 reopened this Jan 14, 2026
@paulb777
Copy link
Member Author

Merging since test failures are unrelated.

@paulb777 paulb777 merged commit dabf480 into main Jan 14, 2026
115 of 127 checks passed
@paulb777 paulb777 deleted the pb-restore-url-context branch January 14, 2026 23:32
JesusRojass pushed a commit to JesusRojass/firebase-ios-sdk that referenced this pull request Jan 22, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Firebase AI] URL Context tool intermittently throws 500 errors on Google AI

2 participants