Conversation
Explanation: 1. CocoaPods Cleanup: When CocoaPods installs a pod, it cleans the source directory by removing any files that are not explicitly declared in the podspec (via source_files, resources, preserve_paths, etc.). 2. Missing Headers: Before your change, the re2 headers located in Firestore/third_party/re2 were not listed in source_files (since they are excluded or not matched) and were missing from preserve_paths. As a result, CocoaPods deleted them. 3. Broken Search Path: Although HEADER_SEARCH_PATHS correctly pointed to /Firestore/third_party/re2, the compilation failed because the files had been removed from the disk. 4. The Fix: Adding 'Firestore/third_party/re2/**/*.h' to preserve_paths explicitly tells CocoaPods to keep these files. This ensures they exist on disk during the build, allowing the compiler to resolve #include re2/re2.h. #no-changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
paulb777
left a comment
There was a problem hiding this comment.
LGTM
Please test locally or trigger CI for one of the failing nightlies to confirm.
This reverts commit 395dc89.
|
I'm going to merge this and see how nightlies respond. I waited for manual (pre)release_cocoapods workflows but realized that I shouldn't have since the tags they were testing do not include this fix. I was able to successfully stage the fixed spec in this PR to SpecsStaging. Going to merge and move tags. |
Address re2 header related nightlies #15607 (comment)
Gemini Explanation:
Testing
Fixes #15607
#no-changelog