Skip to content

[Infra] Update CI action specifiers to full commit SHAs#15633

Merged
paulb777 merged 12 commits intomainfrom
pb-test-actions
Dec 20, 2025
Merged

[Infra] Update CI action specifiers to full commit SHAs#15633
paulb777 merged 12 commits intomainfrom
pb-test-actions

Conversation

@paulb777
Copy link
Member

No description provided.

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@paulb777 paulb777 changed the title [DO NOT MERGE] Testing actions [Infra] Update CI action specifiers to full commit SHAs Dec 19, 2025
@paulb777
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves security by pinning the actions/upload-artifact action to a specific commit SHA. This is a great practice. However, the version number in the comment next to the SHA appears to be incorrect. I've left a suggestion to update it for accuracy and future maintainability.

@paulb777 paulb777 requested a review from ncooke3 December 20, 2025 00:19
@ncooke3
Copy link
Member

ncooke3 commented Dec 20, 2025

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@paulb777
Copy link
Member Author

Looks like a legit failure: https://github.com/firebase/firebase-ios-sdk/actions/runs/20385968335/job/58586888378?pr=15633

Not sure why, looking.

Looks like a flake. The rerun succeeded.

@paulb777 paulb777 merged commit 1d73daf into main Dec 20, 2025
646 of 654 checks passed
@paulb777 paulb777 deleted the pb-test-actions branch December 20, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants