Skip to content

feat: improve build.sh logging and add dry run feature#15615

Merged
ncooke3 merged 1 commit intomainfrom
nc/imp-script-logging
Dec 17, 2025
Merged

feat: improve build.sh logging and add dry run feature#15615
ncooke3 merged 1 commit intomainfrom
nc/imp-script-logging

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 17, 2025

build.sh prints the xcodebuild command, but it's not copy-and-paste friendly due to unescaped spaces:

  xcodebuild -scheme FirebaseSessionsUnit -destination platform=iOS Simulator,name=iPhone 16e ONLY_ACTIVE_ARCH=YES CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=YES COMPILER_INDEX_STORE_ENABLE=NO IPHONEOS_DEPLOYMENT_TARGET=13.0 TVOS_DEPLOYMENT_TARGET=13.0 test

The -destination platform=iOS Simulator,name=iPhone 16e will cause problems.

With this fix:

xcodebuild -scheme FirebaseSessionsUnit -destination platform=iOS\ Simulator\,name=iPhone\ 16 ONLY_ACTIVE_ARCH=YES CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=YES COMPILER_INDEX_STORE_ENABLE=NO IPHONEOS_DEPLOYMENT_TARGET=13.0 TVOS_DEPLOYMENT_TARGET=13.0 test

Which is copy-and-paste friendly.

Also add a dry run feature, which is useful for getting the xcodebuild command for the desired scheme & platform, without actually executing the command.

DRY_RUN=true ./scripts/build.sh FirebaseSessionsUnit iOS spm

Full example:

 % DRY_RUN=true ./scripts/build.sh FirebaseSessionsUnit iOS spm
Building FirebaseSessionsUnit for iOS using spm
GITHUB_BASE_REF: 
GITHUB_HEAD_REF: 
xcodebuild -scheme FirebaseSessionsUnit -destination platform=iOS\ Simulator\,name=iPhone\ 16 ONLY_ACTIVE_ARCH=YES CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=YES COMPILER_INDEX_STORE_ENABLE=NO IPHONEOS_DEPLOYMENT_TARGET=13.0 TVOS_DEPLOYMENT_TARGET=13.0 test
DRY_RUN is set. Exiting before build.

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@ncooke3 ncooke3 merged commit 9a119d3 into main Dec 17, 2025
93 of 95 checks passed
@ncooke3 ncooke3 deleted the nc/imp-script-logging branch December 17, 2025 16:50
JesusRojass pushed a commit to JesusRojass/firebase-ios-sdk that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants