Skip to content

Manually set cmake version in github action #14775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cherylEnkidu merged 4 commits into from
Apr 30, 2025
+31 −1
Merged

Manually set cmake version in github action #14775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abd8560
Manually set cmake version
cherylEnkidu Apr 25, 2025
fc8220f
Update firestore.yml
cherylEnkidu Apr 25, 2025
54b5b9f
set flag
cherylEnkidu Apr 25, 2025
ff55285
address comments
cherylEnkidu Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/firestore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ jobs:

env:
MINT_PATH: ${{ github.workspace }}/mint
USE_LATEST_CMAKE: false

runs-on: ${{ matrix.os }}
steps:
Expand All @@ -142,6 +143,11 @@ jobs:
with:
python-version: '3.11'

- name: Setup cmake
uses: jwlawson/actions-setup-cmake@v2
with:
cmake-version: '3.31.1'

- name: Setup build
run: scripts/install_prereqs.sh Firestore ${{ runner.os }} cmake

Expand All @@ -168,6 +174,7 @@ jobs:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
MINT_PATH: ${{ github.workspace }}/mint
TARGET_DATABASE_ID: ${{ matrix.databaseId }}
USE_LATEST_CMAKE: false

runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -230,6 +237,11 @@ jobs:
GOOGLE_APPLICATION_CREDENTIALS: ../google-service-account.json
continue-on-error: true

- name: Setup cmake
uses: jwlawson/actions-setup-cmake@v2
with:
cmake-version: '3.31.1'

- name: Setup build
run: scripts/install_prereqs.sh Firestore ${{ runner.os }} cmake

Expand All @@ -255,6 +267,7 @@ jobs:

env:
SANITIZERS: ${{ matrix.sanitizer }}
USE_LATEST_CMAKE: false

steps:
- uses: actions/checkout@v4
Expand All @@ -271,6 +284,11 @@ jobs:
with:
python-version: '3.11'

- name: Setup cmake
uses: jwlawson/actions-setup-cmake@v2
with:
cmake-version: '3.31.1'

- name: Setup build
run: scripts/install_prereqs.sh Firestore ${{ runner.os }} cmake

Expand Down Expand Up @@ -301,6 +319,7 @@ jobs:
env:
SANITIZERS: ${{ matrix.sanitizer }}
ASAN_OPTIONS: detect_leaks=0
USE_LATEST_CMAKE: false

steps:
- uses: actions/checkout@v3
Expand All @@ -317,6 +336,11 @@ jobs:
with:
python-version: '3.11'

- name: Setup cmake
uses: jwlawson/actions-setup-cmake@v2
with:
cmake-version: '3.31.1'

- name: Setup build
run: scripts/install_prereqs.sh Firestore ${{ runner.os }} cmake

Expand Down
8 changes: 7 additions & 1 deletion scripts/install_prereqs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,13 @@ case "$project-$platform-$method" in
;;

Firestore-iOS-cmake | Firestore-tvOS-cmake | Firestore-macOS-cmake)
brew outdated cmake || brew upgrade cmake
# Only skip upgrade when explicitly ask for
if [[ "${USE_LATEST_CMAKE:-true}" == "true" ]]; then
echo "Use latest CMake because USE_LATEST_CMAKE=true"
brew outdated cmake || brew upgrade cmake
else
echo "Skipping CMake upgrade"
fi
brew outdated go || brew upgrade go # Somehow the build for Abseil requires this.
brew install ccache
brew install ninja
Expand Down
Loading