[Firebase AI] Add Swift package product library FirebaseAI#14773
[Firebase AI] Add Swift package product library FirebaseAI#14773paulb777 merged 4 commits intofirebase-aifrom
FirebaseAI#14773Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Generated by 🚫 Danger |
|
No concerns
…On Thu, Apr 24, 2025, 7:30 PM Andrew Heard ***@***.***> wrote:
*andrewheard* left a comment (firebase/firebase-ios-sdk#14773)
<#14773 (comment)>
@paulb777 <https://github.com/paulb777> Any concerns with ignoring
Firestore cmake
<https://github.com/firebase/firebase-ios-sdk/actions/runs/14655590620/job/41130059789?pr=14773>
?
—
Reply to this email directly, view it on GitHub
<#14773 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASBDWUDYKSTWICBMOQMX323GM2TAVCNFSM6AAAAAB32IY5SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRZGI2DAOBQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
libraryforFirebaseAIto the publicproductsinPackage.swift.FirebaseAIin alphabetical order (FirebaseVertexAIkept nearby but will be removed in a breaking change).firebaseAItocreateInstanceinFirebaseAI.Naming Consistency: The naming of the internal initializer
firebaseAI(app:location:apiConfig:)inFirebaseAI.swiftis a bit confusing, as it shares the same name as the public API. Consider renaming the internal initializer to something more descriptive, likecreateFirebaseAIInstance.