-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linkDomain support for ActionCodeSettting. This will generate Hosting-formatted email link. #13991
Open
Xiaoshouzi-gh
wants to merge
3
commits into
main
Choose a base branch
from
fdl-dep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add linkDomain support for ActionCodeSettting. This will generate Hosting-formatted email link. #13991
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -226,6 +226,89 @@ class AuthenticationExampleUITests: XCTestCase { | |
removeUIInterruptionMonitor(interruptionMonitor) | ||
} | ||
|
||
func testEmailLinkSentSuccessfully() { | ||
app.staticTexts["Email Link/Passwordless"].tap() | ||
|
||
let testEmail = "[email protected]" | ||
app.textFields["Enter Authentication Email"].tap() | ||
app.textFields["Enter Authentication Email"].typeText(testEmail) | ||
app.buttons["return"].tap() // Dismiss keyboard | ||
app.buttons["Send Sign In Link"].tap() | ||
|
||
// Wait for the error message to appear (if there is an error) | ||
let errorAlert = app.alerts.staticTexts["Error"] | ||
let errorExists = errorAlert.waitForExistence(timeout: 5.0) | ||
|
||
app.swipeDown(velocity: .fast) | ||
|
||
// Assert that there is no error message (success case) | ||
// The email sign in link is sent successfully if no error message appears | ||
XCTAssertFalse(errorExists, "Error") | ||
|
||
// Go back and check that there is no user that is signed in | ||
app.tabBars.firstMatch.buttons.element(boundBy: 1).tap() | ||
wait(forElement: app.navigationBars["User"], timeout: 5.0) | ||
XCTAssertEqual( | ||
app.cells.count, | ||
0, | ||
"The user shouldn't be signed in and the user view should have no cells." | ||
) | ||
} | ||
|
||
func testResetPasswordLinkCustomDomain() { | ||
// assuming action type is in-app + continue URL everytime the app launches | ||
|
||
// set Authorized Domain as Continue URL | ||
let testContinueURL = "fir-ios-auth-sample.firebaseapp.com" | ||
app.staticTexts["Continue URL"].tap() | ||
app.alerts.textFields.element.typeText(testContinueURL) | ||
app.buttons["Save"].tap() | ||
|
||
// set Custom Hosting Domain as Link Domain | ||
let testLinkDomain = "http://firebaseiosauthsample.testdomaindonotuse.com" | ||
app.staticTexts["Link Domain"].tap() | ||
app.alerts.textFields.element.typeText(testLinkDomain) | ||
app.buttons["Save"].tap() | ||
|
||
app.staticTexts["Request Password Reset"].tap() | ||
let testEmail = "[email protected]" | ||
app.alerts.textFields.element.typeText(testEmail) | ||
app.buttons["Save"].tap() | ||
|
||
// Go back and check that there is no user that is signed in | ||
app.tabBars.firstMatch.buttons.element(boundBy: 1).tap() | ||
wait(forElement: app.navigationBars["User"], timeout: 5.0) | ||
XCTAssertEqual( | ||
app.cells.count, | ||
0, | ||
"The user shouldn't be signed in and the user view should have no cells." | ||
) | ||
} | ||
|
||
func testResetPasswordLinkDefaultDomain() { | ||
// assuming action type is in-app + continue URL everytime the app launches | ||
|
||
// set Authorized Domain as Continue URL | ||
let testContinueURL = "fir-ios-auth-sample.firebaseapp.com" | ||
app.staticTexts["Continue URL"].tap() | ||
app.alerts.textFields.element.typeText(testContinueURL) | ||
app.buttons["Save"].tap() | ||
|
||
app.staticTexts["Request Password Reset"].tap() | ||
let testEmail = "[email protected]" | ||
app.alerts.textFields.element.typeText(testEmail) | ||
app.buttons["Save"].tap() | ||
|
||
// Go back and check that there is no user that is signed in | ||
app.tabBars.firstMatch.buttons.element(boundBy: 1).tap() | ||
wait(forElement: app.navigationBars["User"], timeout: 5.0) | ||
XCTAssertEqual( | ||
app.cells.count, | ||
0, | ||
"The user shouldn't be signed in and the user view should have no cells." | ||
) | ||
} | ||
|
||
// MARK: - Private Helpers | ||
|
||
private func signOut() { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be marked deprecated? Or wait until next release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I mark this as deprecated, our test failed due to build warnings. Any suggestions? I still want to keep the dynamicLinkDomain tests because both solutions will be available until FDL sunset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can temporarily add
--allow-warnings
with a comment to thepod lib lint
test invocations