Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Update binary SPM Firestore distro for 10.24.0 #12708

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[Release] Update binary SPM Firestore distro for 10.24.0 #12708

merged 1 commit into from
Apr 4, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 4, 2024

#no-changelog

@ncooke3 ncooke3 requested a review from paulb777 April 4, 2024 20:59
@ncooke3
Copy link
Member Author

ncooke3 commented Apr 4, 2024 •
edited
Loading

I'm working on re-publishing the FST deps right now (because of the macOS/Catalyst framework changes). Do you think we should pin to their new versions in the Firebase Package.swift?

I think if CI passes as is, maybe no to be less restrictive in case something else goes wrong.

@paulb777
Copy link
Member

paulb777 commented Apr 4, 2024

So the FST updates will be patch version updates?

It might be better to pin to the update since we know the current version is bad (and not detectable until App Store deployment)

@ncooke3
Copy link
Member Author

ncooke3 commented Apr 4, 2024

So the FST updates will be patch version updates?

Yes

paulb777
paulb777 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK either way on updating the absl and grpc deps.

@ncooke3
Copy link
Member Author

ncooke3 commented Apr 4, 2024

I'm OK either way on updating the absl and grpc deps.

Will do so in a follow-up PR!

@ncooke3 ncooke3 merged commit 9161a40 into main Apr 4, 2024
58 of 59 checks passed
@ncooke3 ncooke3 deleted the nc/stage0m146 branch April 4, 2024 21:37
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Apr 9, 2024
@cgrindel-self-hosted-renovate
chore(deps): update dependency firebase/firebase-ios-sdk to from: "10…
0198e45 
….24.0" (#1007)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://github.com/firebase/firebase-ios-sdk)
| minor | `from: "10.23.1"` -> `from: "10.24.0"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.24.0`](https://github.com/firebase/firebase-ios-sdk/releases/tag/10.24.0):
Firebase Apple 10.24.0

[Compare
Source](https://github.com/firebase/firebase-ios-sdk/compare/10.23.1...10.24.0)

The Firebase Apple SDK (10.24.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.24.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- Remove calls to fstat in crashlytics by
[@&#8203;volantwish](https://github.com/volantwish) in
[firebase/firebase-ios-sdk#12531
- fix unit tests by
[@&#8203;themiswang](https://github.com/themiswang) in
[firebase/firebase-ios-sdk#12553
- \[Release] Add release note for signed artifact changes by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12558
- Fix typo by [@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12565
- \[Firestore] Add a check to ensure FirestoreInternal has same public
headers as Firestore by [@&#8203;ncooke3](https://github.com/ncooke3)
in
[firebase/firebase-ios-sdk#12575
- Carthage 10.23.0 by [@&#8203;paulb777](https://github.com/paulb777)
in
[firebase/firebase-ios-sdk#12588
- Initial CI for visionOS by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12578
- Upgrade cmake build to grpc 162 by
[@&#8203;wu-hui](https://github.com/wu-hui) in
[firebase/firebase-ios-sdk#12417
- More visionOS CI by [@&#8203;paulb777](https://github.com/paulb777)
in
[firebase/firebase-ios-sdk#12608
- Update versions for Release 10.24.0 by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12594
- \[Release Tooling] Update XCFramework structure by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12595
- \[Docs] Update `FirebaseCore/CHANGELOG.md` with correct issue # by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12639
- Adds putFileHandle and putFileHandleAsync by
[@&#8203;mattcomi](https://github.com/mattcomi) in
[firebase/firebase-ios-sdk#12580
- \[CocoaPods] Lock FirestoreInternal version to Firestore by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12654
- Merge 10.23.1 by [@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12655
- \[Crashlytics] Fix missing Swift header error by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12659
- Move MIEQ to composite index tests by
[@&#8203;milaGGL](https://github.com/milaGGL) in
[firebase/firebase-ios-sdk#12416
- feat: add basic support to build frameworks and zip them for the Apple
Watch by [@&#8203;jasesuperhero](https://github.com/jasesuperhero) in
[firebase/firebase-ios-sdk#12624
- Release note for watchOS zip/Carthage by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12670
- \[Crashlytics] Remove mach_absolute_time usages by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12664
- Update to SwiftFormat 0.53.5 by
[@&#8203;paulb777](https://github.com/paulb777) in
[firebase/firebase-ios-sdk#12665
- Fix typo: Timout -> Timeout by
[@&#8203;Jager-yoo](https://github.com/Jager-yoo) in
[firebase/firebase-ios-sdk#12672
- \[Crashlytics] Regenerate privacy manifest by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12675
- \[Release] Version changelog entries for 10.24.0 by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12677
- \[Release Tooling] Fix METADATA.md regression introduced in
[#&#8203;12595](https://github.com/firebase/firebase-ios-sdk/issues/12595)
by [@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12661
- Analytics 10.24.0 by
[@&#8203;tsunghung](https://github.com/tsunghung) in
[firebase/firebase-ios-sdk#12693
- \[Release] Update binary SPM Firestore distro for 10.24.0 by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12708
- \[Release] Update Firestore's binary deps in Package.swift by
[@&#8203;ncooke3](https://github.com/ncooke3) in
[firebase/firebase-ios-sdk#12709

#### New Contributors

- [@&#8203;volantwish](https://github.com/volantwish) made their first
contribution in
[firebase/firebase-ios-sdk#12531
- [@&#8203;mattcomi](https://github.com/mattcomi) made their first
contribution in
[firebase/firebase-ios-sdk#12580
- [@&#8203;jasesuperhero](https://github.com/jasesuperhero) made their
first contribution in
[firebase/firebase-ios-sdk#12624
- [@&#8203;Jager-yoo](https://github.com/Jager-yoo) made their first
contribution in
[firebase/firebase-ios-sdk#12672

**Full Changelog**:
firebase/firebase-ios-sdk@10.23.1...10.24.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncooke3 @paulb777