Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate asan on ubuntu #12165

Merged
merged 12 commits into from
Dec 11, 2023
Merged

Activate asan on ubuntu #12165

merged 12 commits into from
Dec 11, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Dec 4, 2023 •
edited
Loading

see b/260248007

@google-oss-bot
Copy link

google-oss-bot commented Dec 4, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.14% (4713181) to 88.09% (75ef6bf) by -0.05%.

    FilenameBase (4713181)Merge (75ef6bf)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.33%98.82%+0.49%
    leveldb_remote_document_cache.cc94.83%96.55%+1.72%
    ordered_code.cc93.90%94.39%+0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Rmwp4x8jX8.html

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@wu-hui wu-hui changed the title Activate tsan on ubuntu Activate asan on ubuntu Dec 6, 2023
@wu-hui wu-hui requested a review from ehsannas December 7, 2023 19:31
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Dec 8, 2023
@wu-hui wu-hui merged commit 6c40bd5 into master Dec 11, 2023
51 checks passed
@wu-hui wu-hui deleted the wuandy/ReenableTSAN branch December 11, 2023 17:53
@firebase firebase locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@wu-hui wu-hui

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @ehsannas