Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: Add Objective C API build tests #12117

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Auth: Add Objective C API build tests #12117

merged 8 commits into from
Nov 22, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 18, 2023 •
edited
Loading

TODO: enum and typedef testing

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Nov 20, 2023 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseAuth

    TypeBase (bbd2d09)Merge (5845fcf)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fAAqlTudZT.html

@paulb777 paulb777 mentioned this pull request Nov 20, 2023
Merged
@paulb777
Copy link
Member Author

Merging. I'll address any additional comments in a subsequent PR

@paulb777 paulb777 merged commit e193ee7 into master Nov 22, 2023
67 checks passed
@paulb777 paulb777 deleted the pb-objc-api branch November 22, 2023 04:53
@firebase firebase locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@renkelvin renkelvin Awaiting requested review from renkelvin

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @ncooke3