Address code review feedback (not including tests)

firebase · Feb 2, 2019 · b98e874 · wilhuff · Feb 2, 2019 · b98e874
1 parent 7dd421e
commit b98e874
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 31 deletions.
diff --git a/Firestore/Swift/Source/Codable/CodableErrors.swift b/Firestore/Swift/Source/Codable/CodableErrors.swift
@@ -14,10 +14,10 @@
  * limitations under the License.
  */
 
-enum FirestoreDecodingError: Error {
+internal enum FirestoreDecodingError: Error {
   case decodingIsNotSupported
 }
 
-enum FirestoreEncodingError: Error {
+internal enum FirestoreEncodingError: Error {
   case encodingIsNotSupported
 }
diff --git a/Firestore/Swift/Source/Codable/CodablePassThroughTypes.swift b/Firestore/Swift/Source/Codable/CodablePassThroughTypes.swift
@@ -17,7 +17,7 @@
 import Foundation
 import FirebaseFirestore
 
-func isCodablePassThroughType<T: Any>(_ value: T) -> Bool {
+internal func isFirestorePassthroughType<T: Any>(_ value: T) -> Bool {
   return
     T.self == GeoPoint.self ||
     T.self == DocumentReference.self ||

diff --git a/Firestore/Swift/Source/Codable/EncodeOrDie.swift b/Firestore/Swift/Source/Codable/EncodeOrDie.swift
diff --git a/Firestore/Swift/Source/Codable/third_party/FirestoreDecoder.swift b/Firestore/Swift/Source/Codable/third_party/FirestoreDecoder.swift
@@ -1005,7 +1005,7 @@ extension _FirestoreDecoder {
       return (decimal as! T)
     }
     if let _ = value as? Codable {
-      if isCodablePassThroughType(value as! T) {
+      if isFirestorePassthroughType(value as! T) {
         // All the native Firestore types that should not be encoded
         return (value as! T)
       }

diff --git a/Firestore/Swift/Source/Codable/third_party/FirestoreEncoder.swift b/Firestore/Swift/Source/Codable/third_party/FirestoreEncoder.swift
@@ -16,6 +16,14 @@
 import Foundation
 import FirebaseFirestore
 
+internal func encodeOrDie<T: Encodable>(_ value: T) -> [String: Any] {
+  do {
+    return try Firestore.encode(value)
+  } catch let error {
+    fatalError("Unable to encode data with Firestore encoder: \(error)")
+  }
+}
+
 extension Firestore {
   public static func encode<T: Encodable>(_ value: T) throws -> [String: Any] {
     guard let topLevel = try _FirestoreEncoder().box_(value) else {
@@ -342,7 +350,7 @@ extension _FirestoreEncoder {
       return box((value as! URL).absoluteString)
     } else if T.self == Decimal.self || T.self == NSDecimalNumber.self {
       return (value as! NSDecimalNumber)
-    } else if isCodablePassThroughType(value) {
+    } else if isFirestorePassthroughType(value) {
       // These are all native _Firestore types that we don't need to Encode
       return (value as! NSObject)
     }