Add NS_ASSUME_NONNULL_NOTATION for game center sign in (#2359)

firebase · Feb 7, 2019 · 10f50bf · 10f50bf
1 parent e8b0c1f
commit 10f50bf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/Firebase/Auth/Source/AuthProviders/GameCenter/FIRGameCenterAuthCredential.m b/Firebase/Auth/Source/AuthProviders/GameCenter/FIRGameCenterAuthCredential.m
@@ -21,6 +21,8 @@
 #import "FIRGameCenterAuthProvider.h"
 #import "FIRVerifyAssertionRequest.h"
 
+NS_ASSUME_NONNULL_BEGIN
+
 @implementation FIRGameCenterAuthCredential
 
 - (nullable instancetype)initWithProvider:(NSString *)provider {
@@ -84,3 +86,5 @@ - (void)encodeWithCoder:(NSCoder *)aCoder {
 }
 
 @end
+
+NS_ASSUME_NONNULL_END
diff --git a/Firebase/Auth/Source/AuthProviders/GameCenter/FIRGameCenterAuthProvider.m b/Firebase/Auth/Source/AuthProviders/GameCenter/FIRGameCenterAuthProvider.m
@@ -22,6 +22,8 @@
 #import "FIRAuthExceptionUtils.h"
 #import "FIRGameCenterAuthCredential.h"
 
+NS_ASSUME_NONNULL_BEGIN
+
 @implementation FIRGameCenterAuthProvider
 
 - (instancetype)init {
@@ -37,7 +39,7 @@ + (void)getCredentialWithCompletion:(FIRGameCenterCredentialCallback)completion
    checking whether the APP that consuming our SDK has linked GameKit.framework. If not, a
    `GameKitNotLinkedError` will be raised.
    **/
-  GKLocalPlayer *optionalLocalPlayer = [[NSClassFromString(@"GKLocalPlayer") alloc] init];
+  GKLocalPlayer * _Nullable optionalLocalPlayer = [[NSClassFromString(@"GKLocalPlayer") alloc] init];
 
   if (!optionalLocalPlayer) {
     if (completion) {
@@ -82,3 +84,5 @@ + (void)getCredentialWithCompletion:(FIRGameCenterCredentialCallback)completion
 }
 
 @end
+
+NS_ASSUME_NONNULL_END