Firebase Functions 7.0.0 #1758
Firebase Functions 7.0.0 #1758
Conversation
Upgrades from TypeScript v4.3.5 to v5.9.3. All tests pass successfully.
* BREAKING: Drop Node.js 14/16 support, require Node.js >=18 - Update package.json engines to require Node.js >=18.0.0 - Upgrade @types/node from v14 to v18 - Update TypeScript target from ES2019 to ES2022 - Add useDefineForClassFields: false for backward compatibility - Update CI/CD workflows to test Node.js 18, 20, 22, and 24 - Set default CI/CD Node.js version to 24 - Update integration test documentation
Replace functions.config() implementation with an error that provides clear migration guidance to the params module. This removes the deprecated API as planned for the next major release while helping developers migrate. The error message directs users to: https://firebase.google.com/docs/functions/config-env#migrate-config
Upgraded eslint to v9 and replaced the legacy .eslintrc.js with the new eslint.config.js format. Applied minor fixes to 4 files (renaming unused catch variables to _e and one small refactor) to satisfy slightly stricter baseline rules from updated plugins. Mostly doing this due to our upgrade in TS to latest v5 version which the old versions of eslint ts plugins no longer support.
BREAKING CHANGE: Unhandled errors in async onRequest handlers now immediately return a 500 Internal Server Error instead of hanging until timeout. This may affect clients relying on 504 Gateway Timeout for retry logic.
Type out `functions.config()` API. Use of `functions.config()` API should now cause a BUILD error at compile time.
```ts
import * as functions from "firebase-functions";
import {onRequest} from "firebase-functions/https";
import * as logger from "firebase-functions/logger";
const cfg = functions.config()
export const helloWorld = onRequest((request, response) => {
logger.info("Hello logs!", cfg);
response.send("Hello from Firebase!");
});
```
```bash
$ npm run build
> build
> tsc
src/index.ts:5:23 - error TS2349: This expression is not callable.
Type 'never' has no call signatures.
5 const cfg = functions.config()
~~~~~~
Found 1 error in src/index.ts:5
```
* Add Firebase Data Connect v2 support * Export dataconnect * Fix export * Rename Extract to VarName, since Extract is a built in type * Include auth context in event payload * Stronger typing for data connect params * Fix formatting and address comments * Apply another suggestion * Add region and fix bug in which event.service, event.connector, event.operation gets populated * Remove locations/... segment * Address comments
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents a significant update to the Firebase Functions SDK, bumping it to version 7.0.0. The changes focus on modernizing the development environment by adopting the new ESLint flat configuration and upgrading core dependencies. It also expands the SDK's capabilities by introducing event handlers for Firebase Data Connect, allowing developers to build more integrated solutions. Concurrently, it streamlines error handling for asynchronous HTTP functions and formally deprecates an older configuration API, guiding users towards more current and robust practices. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a major version bump to 7.0.0, bringing several modernizations to the codebase. Key changes include upgrading to ESLint's flat config, updating the TypeScript target to ES2022, enabling esModuleInterop for cleaner imports, and dropping support for Node.js versions below 18. A significant and welcome change is the removal of the deprecated functions.config() in favor of environment parameters. The introduction of the new dataconnect provider and improved error handling for HTTPS onRequest handlers are also notable improvements. My review focuses on potential issues in the new configurations and implementations to ensure robustness and correctness.
- Configure tsdown to build both CJS and ESM outputs. - Update package.json exports to support both 'require' and 'import'. - Fix type hygiene issues by using explicit 'export type'. - Update protos/update.sh to generate ESM version of compiledFirestore and fix its imports for Node.js compatibility. - Configure build aliases to handle relative paths to protos correctly in both CJS and ESM builds. - Add packaging integration test to CI. ~Note: I enabled `esModuleInterop` in tsconfig.release.json to support default imports from CommonJS modules (like cors), which is required for proper ESM interop. This caused some chain-effect that required updating several unit tests and source files to use default imports for other CJS dependencies (e.g., fs, nock, jsonwebtoken) to align with the new compiler configuration.~ Fixed in #1751.
|
/gemini review |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a major version update to firebase-functions. Key changes include upgrading the minimum Node.js version to 18, removing the deprecated functions.config() API in favor of environment parameters, and overhauling the build system to support dual CJS/ESM modules using tsdown. The ESLint configuration has been modernized to the new flat config format. A new dataconnect provider is introduced. A critical bug fix for unhandled promise rejections in onRequest handlers has been implemented. Additionally, robust packaging tests have been added to verify module exports. The changes are extensive and well-executed, significantly improving the SDK's architecture and developer experience. My feedback includes a minor suggestion to improve script maintainability.
There was a problem hiding this comment.
Code Review
This pull request introduces a major version bump to 7.0.0, bringing a significant modernization to the firebase-functions SDK. Key improvements include a new build system using tsdown for dual CJS/ESM support, migration to ESLint's flat config, and an upgrade to Node.js 18. The removal of the deprecated functions.config() is a notable breaking change, handled cleanly with clear migration guidance. I'm also excited to see the new dataconnect provider and the addition of robust error handling for unhandled promises in HTTPS functions, which will greatly improve developer experience and function stability. The new packaging tests are an excellent addition for ensuring package integrity. Overall, this is a high-quality update with well-executed changes. I have a few minor suggestions to further improve the code.
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
3 participants
Breaking: Minimum Node.js version is now 18. As of v7.0.0, the SDK requires a Node.js runtime of version 18 or newer. Support for Node.js 14 and 16 has been removed.
Breaking: The functions.config() API has been removed. Following the deprecation schedule announced in v6.0.0, functions.config() has been removed entirely.
Breaking: TypeScript v5 is now required. The SDK has been upgraded from TypeScript v4.3 to v5.9 and now targets ES2022.
Breaking: Improved error handling for async handlers in the Emulator. We have improved how unhandled errors are processed in the Local Emulator Suite. Previously, an unhandled error or rejected Promise in an async onRequest handler would cause the request to hang until a platform timeout.
Feature: The SDK is now published as both CommonJS (CJS) and ECMAScript Modules (ESM). This provides first-class support for modern bundlers (like Vite and esbuild) and native import syntax, which can lead to optimized function sources and smaller bundle sizes. The package.json exports map now properly resolves for both require and import.
Feature: New FDC Trigger This release adds a new function trigger for Firebase Data Connect (FDC), onMutationExecuted(). This allows you to execute functions in response to data mutations.