Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry in event triggers #1463

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Fix retry in event triggers #1463

merged 5 commits into from
Aug 23, 2024

Conversation

colerogers
Copy link
Contributor

@colerogers colerogers commented Sep 22, 2023

Links up retry for event triggered gen 2 functions. Fixes firebase/firebase-tools#5484

@sarthakydv
Copy link

We need this to go in

Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use nullish coalescing instead of logical or.

@taeold taeold merged commit 2358cc1 into master Aug 23, 2024
13 checks passed
@taeold taeold deleted the colerogers.enable-function-retry branch August 23, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 functions don't support retry even though cloud functions gen2 do
3 participants