Change type info to be inheritance friendly. #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unwind the cleverness of CloudEvent<EventType, Extensions>. Types now match the approved format of the Python API. CloudFunction now templatizes the CloudEvent rather than the EventType so that we can keep typing to include subtypes of events both in code complete and in firebase-functions-test.
inlined
commented
May 2, 2022
| * part of the CloudEvents spec nor the payload that a Cloud Function | ||
| * actually receives. | ||
| */ | ||
| params?: Record<string, string>; |
There was a problem hiding this comment.
Note: params should probably only be present in Cloud Function types that actually support params.
|
THANK YOU!!! |
TheIronDev
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unwind the cleverness of CloudEvent<EventType, Extensions>. Types
now match the approved format of the Python API. CloudFunction now
templatizes the CloudEvent rather than the EventType so that we can
keep typing to include subtypes of events both in code complete and
in firebase-functions-test.
CC @TheIronDev since this affects firebase-functions-test