Skip to content

Conversation

@dconeybe
Copy link
Contributor

Android builds in Windows GitHub Actions runners was curiously failing with "firestore_errors.h file not found" errors (e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6387651127). It turned out that this was because the cloning of the https://github.com/firebase/firebase-ios-sdk repository was failing due to such a deeply-nested filesystem hierarchy that it exceeded the maximum path lengths.

The fix in this PR enables "long paths" support in Git to disable this troublesome limitation by running

git config --system core.longpaths true

Here is one explanation of this fix: https://stackoverflow.com/a/72187507

Credit for this fix goes completely to @wu-hui (#967). I'm merely porting it to the main branch.

@dconeybe dconeybe added api: firestore skip-release-notes Skip release notes check labels May 30, 2022
@dconeybe dconeybe self-assigned this May 30, 2022
@dconeybe dconeybe requested a review from wu-hui May 30, 2022 11:40
@dconeybe dconeybe assigned wu-hui and unassigned dconeybe May 30, 2022
@wu-hui wu-hui assigned dconeybe and unassigned wu-hui May 30, 2022
@dconeybe dconeybe merged commit 1246cc8 into main May 30, 2022
@dconeybe dconeybe deleted the dconeybe/GitLongPathsSupportWindows branch May 30, 2022 15:01
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 30, 2022
@github-actions
Copy link

github-actions bot commented May 30, 2022

❌  Integration test FAILED

Requested by @dconeybe on commit 1246cc8
Last updated: Mon May 30 11:30 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: emulator_target]
[TEST] [ERROR] [iOS] [macos] [1/2 ios_device: simulator_target]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 30, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 30, 2022
@firebase firebase locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants