Skip to content

In the Test Summary Report, add "x/y" which means "x" out of "y" configs has errors. #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 19, 2022
Merged

In the Test Summary Report, add "x/y" which means "x" out of "y" configs has errors. #812

merged 4 commits into from
Jan 19, 2022

Conversation

@sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Jan 12, 2022

Description

In the Test Summary Report, add "x/y" which means "x" out of "y" configs has errors.

Testing

See comment below

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 12, 2022
@github-actions
Copy link

github-actions bot commented Jan 12, 2022 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @sunmou99 on commit 783ec81
Last updated: Wed Jan 19 15:25 PST 2022
View integration test log & download artifacts

Failures Configs
database [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseDatabaseTest.TestInfoConnected
storage [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@sunmou99 sunmou99 added the skip-release-notes Skip release notes check label Jan 12, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jan 12, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2022
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jan 12, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 12, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jan 12, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2022
@github-actions github-actions bot removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jan 12, 2022
@sunmou99 sunmou99 requested a review from jonsimantov January 12, 2022 19:04
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jan 12, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 12, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jan 12, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jan 12, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 13, 2022
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jan 14, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jan 14, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. labels Jan 14, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jan 18, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 18, 2022
@sunmou99 sunmou99 removed the tests: failed This PR's integration tests failed. label Jan 19, 2022
@sunmou99 sunmou99 enabled auto-merge (squash) January 19, 2022 20:33
@sunmou99 sunmou99 merged commit 783ec81 into main Jan 19, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jan 19, 2022
@sunmou99 sunmou99 deleted the feature/update-summary-report branch January 19, 2022 20:36
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 19, 2022
DellaBitta added a commit that referenced this pull request Jan 21, 2022
@DellaBitta @jonsimantov
@sunmou99 @a-maurice @dconeybe @firebase-workflow-trigger @cynthiajoan
Merge main into GMA feature branch (#816)
fc18d67 
* Add a delay to the Analytics test app. (#788)

* Add a delay when the Analytics test finishes.

* In the test report, if test failed on all devices. Mark [All x test devices]  (#784)

* Disable -Wnullability-completeness on iOS and macOS. (#782)

* Disable -Wnullability-completeness on iOS and macOS.

* Remove NDK if the cache hit failed.

* Update public documentation for C++ FCM SDK. (#789)

As of Firebase C++ SDK 7.1.0, we started using JobIntentService for scheduling jobs. This change requires a few additional modifications to AndroidManifest.xml and a new way of starting a background service.

These changes were done to the old repository, and need to be brought to GitHub.

* Split mutex.h into .h and .cc files (#751)

* future.h: Fix minor typo in the docs for FutureBase (#794)

* Move mutex.h header to public internal (#792)

* Delete app/src/mutex.h and adjust includes to app/src/include/firebase/internal/mutex.h (#795)

* future.h: replace std::mutex with firebase::Mutex (#798)

* Change setup-gcloud to use @v0 instead of @master as per their readme. (#802)

* fix Log NoneType Error (#807)

* Update Android dependencies - Thu Jan 06 2022 (#809)

[Triggered](https://github.com/firebase/firebase-android-sdk/actions/runs/1665092765) by [firebase-android-sdk Jan 06 release](firebase/firebase-android-sdk@22ee484).

  ### Android

- com.google.android.gms.play_services_base → 18.0.1
- com.google.firebase.firebase_analytics → 20.0.2

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1665095030).

Co-authored-by: firebase-workflow-trigger-bot <[email protected]>

* add -DNOMINMAX to both WIN32 and WIN64 (#810)

* add -DNOMINMAX to both WIN32 and WIN64

* test

* test

* test

* test

* remove helper print

* format code

Co-authored-by: Cynthia Jiang <[email protected]>

* In the Test Summary Report, add "x/y" which means "x" out of "y" configs has errors. (#812)

* mutex header include path

* maven connectivity parameters (#818)

CI scripts invoke gradle in a way to circumvent Azure-to-Maven connection pool timeout issues.

Co-authored-by: Jon Simantov <[email protected]>
Co-authored-by: Mou Sun <[email protected]>
Co-authored-by: a-maurice <[email protected]>
Co-authored-by: Denver Coneybeare <[email protected]>
Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com>
Co-authored-by: firebase-workflow-trigger-bot <[email protected]>
Co-authored-by: Cynthia J <[email protected]>
Co-authored-by: Cynthia Jiang <[email protected]>
@firebase firebase locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sunmou99 @jonsimantov