fix: Ensure analytics desktop dll is copied to the CI pipeline and add new test to verify

[AustinBenoit]

Description

fix: Ensure dll is copied to the CI pipeline and add new test to verify

---

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.
Add in a new integration test to verify that the CI tests load the dll.

---

Type of Change

Place an x the applicable box:

• Bug fix. Add the issue # below if applicable.
• New feature. A non-breaking change which adds functionality.
• Other, such as a build process or documentation change.

This makes sure the windows DLL is copied over to the CI test.

---

Notes

• Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
• Read the contribution guidelines CONTRIBUTING.md.
• Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

[gemini-code-assist]

Summary of Changes

Hello @AustinBenoit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue where the analytics desktop DLL was not consistently available in the CI pipeline for Windows builds. By ensuring the DLL is copied and adding a dedicated integration test, it enhances the reliability of the CI process and validates the correct loading of the analytics module on Windows platforms.

Highlights

• CI Pipeline Fix: Ensured that the analytics desktop DLL is correctly copied to the CI pipeline, addressing potential issues with Windows builds and tests.
• New Integration Test: Added a new integration test, TestIsAnalyticsDllLoaded, specifically for Windows to verify that the analytics DLL is properly loaded within the CI environment.
• Platform-Specific DLL Loading Check: Introduced a new internal function IsAnalyticsDllLoaded() which checks the status of the analytics DLL on Windows and returns false for other platforms like Android and iOS.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new integration test to verify that the analytics DLL is loaded on Windows, which will help ensure the CI pipeline is correctly configured. The implementation introduces an internal function IsAnalyticsDllLoaded with the correct logic for desktop and stub implementations for other platforms. The changes are logical and well-contained. I have one minor suggestion to improve code organization in analytics_desktop.cc.

[gemini-code-assist]

This introduces a second namespace internal block. For better code organization and consistency with other files in this PR (like analytics_android.cc), please consolidate this with the existing namespace internal block at line 136.

[github-actions]

✅  Integration test succeeded!

Requested by @AustinBenoit on commit 275449e
Last updated: Tue Dec 2 20:11 PST 2025
View integration test log & download artifacts