Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update video log names #1672

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Update video log names #1672

merged 1 commit into from
Nov 19, 2024

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Make the video log names more unique


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice merged commit 6b34136 into main Nov 19, 2024
10 checks passed
@a-maurice a-maurice deleted the am-actions_update branch November 19, 2024 21:48
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 19, 2024
Copy link

github-actions bot commented Nov 19, 2024

Integration test with FLAKINESS (succeeded after retry)

Requested by @a-maurice on commit 6b34136
Last updated: Tue Nov 19 16:37 PST 2024
View integration test log & download artifacts

Failures Configs
gma [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestAdViewLoadAdAnchorAdaptiveAd
storage [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  FirebaseStorageTest.TestSignIn

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Nov 20, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 20, 2024
@firebase firebase locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant