Update upload download artifacts to v4 #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
reviewed
Nov 11, 2024
| if: ${{ github.event.inputs.test_packaged_sdk != '' }} | ||
| with: | ||
| name: 'firebase_cpp_sdk.zip' | ||
| workflow: 'cpp-packaging.yml' |
There was a problem hiding this comment.
Will this correctly pull the packaged SDK from that workflow run? It doesn't try to read from the integration test workflows?
There was a problem hiding this comment.
I believe the run-id is the important part, since that should be unique. The Unity test workflow uses it to get the build artifacts, and that worked as expected.
Yep, done. Testing it is a pain, but I tried via debug logging against some test runs, and it seems good. |
cynthiajoan
approved these changes
Nov 13, 2024
github-actions
bot
added
the
tests: in-progress
Integration test with FLAKINESS (succeeded after retry)Requested by @a-maurice on commit 43f3df8
Add flaky tests to go/fpl-cpp-flake-tracker |
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the GitHub actions for upload and download artifacts to v4.
Testing
Packaging Run: https://github.com/firebase/firebase-cpp-sdk/actions/runs/11733979480
Test Run: https://github.com/firebase/firebase-cpp-sdk/actions/runs/11736048885
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.