Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide some private friend functions from swig #1565

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

a-maurice
Copy link
Contributor

@a-maurice a-maurice commented Apr 5, 2024

Description

Provide details of the change, and generalize the change in the PR title above.

Hide some private friend methods from swig, since it is trying to generate C# based on them, when it shouldn't be. This is because a new version of SWIG came out that does this.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

https://github.com/firebase/firebase-unity-sdk/actions/runs/8563655507


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Apr 5, 2024
@a-maurice a-maurice changed the title Hide some private auth functions from swig Hide some private functions from swig Apr 5, 2024
@a-maurice a-maurice changed the title Hide some private functions from swig Hide some private friend functions from swig Apr 5, 2024
@a-maurice a-maurice requested a review from cynthiajoan April 5, 2024 20:11
@a-maurice a-maurice merged commit 6bbda6a into main Apr 5, 2024
30 checks passed
@a-maurice a-maurice deleted the am-hide_from_swig branch April 5, 2024 22:12
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Integration test with FLAKINESS (succeeded after retry)

Requested by @a-maurice on commit 6bbda6a
Last updated: Fri Apr 5 17:11 PDT 2024
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  QueryTest.TestCanExplicitlySortByDocumentId
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(6 failed tests)  ServerTimestampTest.TestServerTimestampsCanReturnEstimatedValue
  ServerTimestampTest.TestServerTimestampsCanReturnPreviousValue
  ServerTimestampTest.TestServerTimestampsWorkViaSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionUpdate
  ServerTimestampTest.TestServerTimestampsWorkViaUpdate
storage [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 6, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 6, 2024
@firebase firebase locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants