Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit SDK version to messaging AAR. #1523

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jan 18, 2024

Description

Provide details of the change, and generalize the change in the PR title above.

Since updating Gradle, omitting this sets the minimum SDK to 1 instead of 14, and adds a host of other issues.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Manually tested receiving notification in the integration_test app on Android emulator.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 18, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 18, 2024
Copy link

github-actions bot commented Jan 18, 2024

❌  Integration test FAILED

Requested by @jonsimantov on commit f15f1da
Last updated: Thu Jan 18 15:17 PST 2024
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [1/2 os: windows] [1/2 android_device: android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov changed the title Add SDK version to messaging AAR. Add explicit SDK version to messaging AAR. Jan 18, 2024
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 18, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 18, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 18, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Jan 18, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 18, 2024
@jonsimantov jonsimantov requested a review from a-maurice January 18, 2024 21:28
@jonsimantov jonsimantov marked this pull request as ready for review January 18, 2024 21:30
@jonsimantov jonsimantov merged commit f15f1da into main Jan 18, 2024
62 of 65 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Jan 18, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 18, 2024
@firebase firebase locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants