Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable WrongInstance test with fixed logic and debug logs #1521

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Re-enable WrongInstance test with fixed logic and debug logs #1521

merged 7 commits into from
Jan 19, 2024

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jan 17, 2024 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Add debug output to the WrongInstance test so that when it does fail, it's possible to see where.

This PR also expands the mutex in the iOS SDK as that's the one that was encountering a race condition.

And it adds handling for network timeout for RequestConsentInfoUpdate.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running integration tests multiple times in a row to confirm the flake is resolved.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 17, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit f618b5c
Last updated: Fri Jan 19 14:49 PST 2024
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 17, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 17, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 17, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Jan 17, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 17, 2024
@github-actions github-actions bot removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jan 17, 2024
@jonsimantov jonsimantov requested a review from a-maurice January 17, 2024 22:34
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 18, 2024
@jonsimantov jonsimantov marked this pull request as ready for review January 18, 2024 01:34
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 18, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 18, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 18, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Jan 18, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 18, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 18, 2024
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jan 18, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 18, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 18, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jan 18, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 19, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 19, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Jan 19, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 19, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 19, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Jan 19, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 19, 2024
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jan 19, 2024
@jonsimantov jonsimantov merged commit f618b5c into main Jan 19, 2024
128 of 153 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jan 19, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 19, 2024
@firebase firebase locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice