-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few flaky tests in several products (Auth, Analytics, Storage, RTDB, Firestore) #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration test with FLAKINESS (succeeded after retry)Requested by @jonsimantov on commit 1f2089b
Add flaky tests to go/fpl-cpp-flake-tracker |
a-maurice
approved these changes
Jan 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some more tests that fail due to flakes, usually because of network instability.
Auth: Add retry in TestLinkAnonymousUserWithEmailCredential.
Analytics: Add retry to TestGetAnalyticsInstanceID, and Android retry to TestResettingGivesNewInstanceId.
Storage: Add additional timestamp logging and switch to verifying against remote timestamp, as FTL device local time is unpredictable.
Database: Switch to verifying against remote timestamp, as FTL device local time is unpredictable.
Firestore: Android tests are now timing out on FTL after 90 minutes, so bump up the FTL timeout by 30 more minutes.
Description
Testing
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.