Skip to content

On Linux, install and use GCC 10 if currently not using 9 or 10. #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonsimantov merged 3 commits into from
Nov 23, 2022
Merged

On Linux, install and use GCC 10 if currently not using 9 or 10. #1151

jonsimantov merged 3 commits into from
Nov 23, 2022

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Nov 22, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

New GitHub Ubuntu runner defaults to GCC 11, which can't build boringssl. Revert to GCC 10.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 22, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 22, 2022
@github-actions
Copy link

github-actions bot commented Nov 22, 2022 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit 4fb938e
Last updated: Wed Nov 23 10:28 PST 2022
View integration test log & download artifacts

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 22, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Nov 22, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 22, 2022
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 22, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 22, 2022
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Nov 23, 2022
@jonsimantov jonsimantov enabled auto-merge (squash) November 23, 2022 06:04
@jonsimantov jonsimantov merged commit 4fb938e into main Nov 23, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Nov 23, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 23, 2022
@firebase firebase locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees

@DellaBitta DellaBitta

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonsimantov @DellaBitta