Adds integration tests for tenant management APIs. #570
Conversation
These tests are skipped by default as multi-tenancy is a paid feature on Google Cloud Identity Platform. To run these tests, --testMultiTenancy flag has to be added. Adds d.ts references for multi-tenancy APIs. Adds default email provider config when backend Auth server returns undefined for emailSignInConfig.
wuyanna
left a comment
wuyanna
left a comment
There was a problem hiding this comment.
Just curious, do these tests call backend production endpoints? How often do they run? And which test project does it use?
|
These tests are calling backend production endpoints. They are currently only run manually before a new binary release of the library is pushed. It is basically a sanity check for our new releases (they act more like e2e tests). They are not specific to one project. |
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
This looks pretty good. Just a couple of suggestions.
test/integration/auth.spec.ts
Outdated
| // Test listTenant pagination. | ||
| return admin.auth().listTenants(1); | ||
| }) | ||
| .then((result) => { |
There was a problem hiding this comment.
Something we do in other SDKs to test list operations is to list everything, and see if the known results appear in the output. Something like:
const allTenantIds = listAndIterateThroughAllTenants();
// scan allTenantIds to see if createdTenants is a subset of it.
src/index.d.ts
Outdated
| * resets, password or email updates, etc). | ||
| */ | ||
| tokensValidAfterTime?: string; | ||
|
|
There was a problem hiding this comment.
These require a review from @egilmorez or somebody from his team. How about we make these changes in a separate PR, so the rest of the code changes don't get blocked on documentation updates?
There was a problem hiding this comment.
I reverted the reference changes. Will have a follow up PR just for that.
Reverts index.d.ts reference changes. These will be added in a separate PR.
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Thanks. LGTM with a nit.
src/index.d.ts
Outdated
| } | ||
|
|
||
| export = admin; | ||
| export = admin; |
3 participants
Adds integration tests for tenant management APIs.
These tests are skipped by default as multi-tenancy is a paid feature on Google Cloud Identity Platform.
To run these tests, --testMultiTenancy flag has to be added.
Adds d.ts references for multi-tenancy APIs.
Adds default email provider config when backend Auth server returns undefined for emailSignInConfig.