Skip to content

Supporting % characters in the URL path #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2017
Merged

Supporting % characters in the URL path #44

merged 1 commit into from
Jul 6, 2017

Conversation

@hiranya911
Copy link
Contributor

Support for handling URLs with % signs in path. For example:

https://test.com/foo%20bar

Fix for #40

@hiranya911 hiranya911 requested a review from jshcrowthe June 19, 2017 20:36
jshcrowthe
jshcrowthe approved these changes Jul 6, 2017
View reviewed changes
Copy link

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, it might be nice to investigate using a 3rd party validation tool for these things. But that can be a later thing.

@jshcrowthe jshcrowthe assigned hiranya911 and unassigned jshcrowthe Jul 6, 2017
@hiranya911 hiranya911 merged commit d532320 into master Jul 6, 2017
@hiranya911 hiranya911 deleted the hkj-fix-40 branch July 6, 2017 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jshcrowthe jshcrowthe jshcrowthe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hiranya911 hiranya911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiranya911 @jshcrowthe