Skip to content

Add assertions for new Remote Config value types in createTemplateFromJSON test #3047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashish-kothari merged 2 commits into from
Dec 31, 2025
Merged

Add assertions for new Remote Config value types in createTemplateFromJSON test #3047

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
761d1cf
Add assertions for new Remote Config value types in createTemplateFro…
google-labs-jules[bot] Dec 31, 2025
f033e39
Refactor Remote Config test assertions to use specific interfaces
google-labs-jules[bot] Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions test/unit/remote-config/remote-config.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,48 @@ describe('RemoteConfig', () => {
expect(p1.description).equals('this is a promo');
expect(p1.valueType).equals('BOOLEAN');

const p2 = newTemplate.parameters['new_ui_enabled'];
expect(p2.defaultValue).deep.equals({ value: 'false' });
expect(p2.conditionalValues).deep.equals({
ios: {
rolloutValue: {
rolloutId: 'rollout_1',
value: 'true',
percent: 50,
}
}
});

@ashish-kothari ashish-kothari Dec 31, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the newly defined interfaces to perform the assertions instead of deep checks. For example, in this case, extract the conditional values into a variable of type RolloutParameterValue and assert on individual fields.

Do the same for subsequent assertions as well for types like PersonalizationParameterValue and ExperimentParameterValue.

@google-labs-jules google-labs-jules Bot Dec 31, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored the assertions to use the explicit RolloutParameterValue, PersonalizationParameterValue, and ExperimentParameterValue interfaces, and asserted on individual fields as requested.

expect(p2.description).equals('New UI Rollout');
expect(p2.valueType).equals('BOOLEAN');

const p3 = newTemplate.parameters['personalized_welcome_message'];
expect(p3.defaultValue).deep.equals({ value: 'Welcome!' });
expect(p3.conditionalValues).deep.equals({
ios: {
personalizationValue: {
personalizationId: 'personalization_1',
}
}
});
expect(p3.description).equals('Personalized Welcome Message');
expect(p3.valueType).equals('STRING');

const p4 = newTemplate.parameters['experiment_enabled'];
expect(p4.defaultValue).deep.equals({ value: 'false' });
expect(p4.conditionalValues).deep.equals({
ios: {
experimentValue: {
experimentId: 'experiment_1',
variantValue: [
{ variantId: 'variant_A', value: 'true' },
{ variantId: 'variant_B', noChange: true }
]
}
}
});
expect(p4.description).equals('Experiment Enabled');
expect(p4.valueType).equals('BOOLEAN');

expect(newTemplate.parameterGroups).deep.equals(PARAMETER_GROUPS);

const c = newTemplate.conditions.find((c) => c.name === 'ios');
Expand Down