Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the property names when initializing the SDK with the ServiceAccount type #2779

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Nov 19, 2024

Fixes: #2769, #2778

@lahirumaramba lahirumaramba added release-note release:stage Stage a release candidate labels Nov 19, 2024
@lahirumaramba lahirumaramba changed the title fix: Fix the property names when initializing the SDK with ServiceAcc… fix: Fix the property names when initializing the SDK with the ServiceAccount type Nov 19, 2024
Copy link
Contributor

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@lahirumaramba lahirumaramba merged commit 380ef0a into master Nov 20, 2024
8 checks passed
@lahirumaramba lahirumaramba deleted the lm-fix-sa-cred branch November 20, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is an error in the type defined in the ServiceAccount
2 participants