Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app-check): support httpAgent in JwksFetcher #2689

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix(app-check): support httpAgent in JwksFetcher #2689

merged 2 commits into from
Sep 4, 2024

Conversation

hermanho
Copy link
Contributor

Fix: support httpAgent in JwksFetcher #2684

@hermanho hermanho force-pushed the fix/jwks-http-proxy branch 4 times, most recently from f94cf42 to ae80c99 Compare August 28, 2024 21:24
@hermanho hermanho marked this pull request as ready for review August 28, 2024 21:28
@lahirumaramba lahirumaramba changed the title fix: support httpAgent in JwksFetcher fix: support httpAgent in JwksFetcher Aug 29, 2024
@lahirumaramba lahirumaramba changed the title fix: support httpAgent in JwksFetcher fix(app-check): support httpAgent in JwksFetcher Aug 29, 2024
lahirumaramba
lahirumaramba approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hermanho for your contribution! LGTM!

@hermanho
Copy link
Contributor Author

For the CI build failed in 22.x, it is related to a bug in nodejs v22.7.0.
protobufjs/protobuf.js#2025
nodejs/node#54518

It should be fixed in v22.8.0. I tested with v22.6.0 in local machine and no problem in emulator-based integration tests.

@lahirumaramba
Copy link
Member

For the CI build failed in 22.x, it is related to a bug in nodejs v22.7.0. protobufjs/protobuf.js#2025 nodejs/node#54518

It should be fixed in v22.8.0. I tested with v22.6.0 in local machine and no problem in emulator-based integration tests.

Yep! Looks like they plan to release 22.8.0 next week. Let's wait and rerun the tests next week. If the Node release is delayed I can update the workflows to pin to 22.6.0

@lahirumaramba lahirumaramba mentioned this pull request Aug 30, 2024
Closed
@lahirumaramba lahirumaramba merged commit 2fb4a27 into firebase:master Sep 4, 2024
8 checks passed
@kenn7575 kenn7575 mentioned this pull request Oct 4, 2024
Merged
@rasheedadultedpro rasheedadultedpro mentioned this pull request Oct 4, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Oct 4, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Oct 4, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 5, 2024
Open
Open
@kenn7575 kenn7575 mentioned this pull request Oct 27, 2024
Closed
@thanbimp thanbimp mentioned this pull request Oct 30, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Oct 30, 2024
Open
@WontonSam WontonSam mentioned this pull request Nov 1, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 4, 2024
Merged
@IvanCastroDev IvanCastroDev mentioned this pull request Nov 4, 2024
Open
@kallie9750 kallie9750 mentioned this pull request Nov 5, 2024
Merged
@thanbimp thanbimp mentioned this pull request Nov 6, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 6, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Nov 6, 2024
Open
@WontonSam WontonSam mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees
No one assigned
Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hermanho @lahirumaramba