Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Added reCAPTCHA and SMS toll fraud configuration support for Phone Authentication #2625

Merged
merged 11 commits into from
Oct 22, 2024
Merged

feat(auth): Added reCAPTCHA and SMS toll fraud configuration support for Phone Authentication #2625

merged 11 commits into from
Oct 22, 2024

Conversation

pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented Jul 10, 2024 •
edited by lahirumaramba
Loading

RELEASE NOTES: Added reCAPTCHA and SMS toll fraud configuration support for Phone Authentication

@pragatimodi pragatimodi changed the title Enable recaptcha enterprise on phone auth [FR] Add recaptcha and sms toll fraud support for phone auth Jul 29, 2024
@pragatimodi pragatimodi changed the title [FR] Add recaptcha and sms toll fraud support for phone auth feat(auth): Add recaptcha and sms toll fraud support for phone auth Jul 29, 2024
pashanka
pashanka reviewed Aug 19, 2024
View reviewed changes
src/auth/auth-config.ts Outdated Show resolved Hide resolved
src/auth/auth-config.ts Outdated Show resolved Hide resolved
src/auth/auth-config.ts Outdated Show resolved Hide resolved
@pragatimodi pragatimodi marked this pull request as draft August 19, 2024 16:45
@pragatimodi pragatimodi marked this pull request as ready for review September 5, 2024 20:07
Xiaoshouzi-gh
Xiaoshouzi-gh approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

etc/firebase-admin.auth.api.md Outdated Show resolved Hide resolved
src/auth/auth-config.ts Show resolved Hide resolved
src/auth/auth-config.ts Show resolved Hide resolved
kevinthecheung
kevinthecheung approved these changes Oct 7, 2024
View reviewed changes
src/auth/auth-config.ts Outdated Show resolved Hide resolved
@lahirumaramba lahirumaramba added release-note release:stage Stage a release candidate labels Oct 8, 2024
@lahirumaramba lahirumaramba merged commit 58b1a36 into master Oct 22, 2024
9 of 10 checks passed
@lahirumaramba lahirumaramba deleted the rce-phoneauth branch October 22, 2024 21:49
lahirumaramba added a commit that referenced this pull request Oct 23, 2024
@lahirumaramba
chore: Update auth.spec.ts
2d8bb63 
- Remove an accidental `describe.only(...`  tag that went in #2625
@lahirumaramba lahirumaramba mentioned this pull request Oct 23, 2024
Merged
lahirumaramba added a commit that referenced this pull request Oct 23, 2024
@lahirumaramba
chore: Update auth.spec.ts (#2737)
0d21e94 
- Remove an accidental `describe.only(...`  tag that went in #2625
@lahirumaramba lahirumaramba changed the title feat(auth): Add recaptcha and sms toll fraud support for phone auth feat(auth): Added reCAPTCHA and sms toll fraud support for phone authentication Oct 23, 2024
@lahirumaramba lahirumaramba changed the title feat(auth): Added reCAPTCHA and sms toll fraud support for phone authentication feat: Added reCAPTCHA and sms toll fraud support Oct 23, 2024
@lahirumaramba lahirumaramba changed the title feat: Added reCAPTCHA and sms toll fraud support feat: Add reCAPTCHA and sms toll fraud support Oct 23, 2024
@lahirumaramba lahirumaramba changed the title feat: Add reCAPTCHA and sms toll fraud support feat(auth): Added support for reCAPTCHA and SMS toll fraud configuration support for Phone Authentication Oct 23, 2024
@lahirumaramba lahirumaramba changed the title feat(auth): Added support for reCAPTCHA and SMS toll fraud configuration support for Phone Authentication feat(auth): Added reCAPTCHA and SMS toll fraud configuration support for Phone Authentication Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pashanka pashanka pashanka left review comments

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

Assignees

@kevinthecheung kevinthecheung

@Xiaoshouzi-gh Xiaoshouzi-gh

Labels
release:stage Stage a release candidate release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pragatimodi @kevinthecheung @Xiaoshouzi-gh @pashanka @lahirumaramba