fix(auth): Memory Leak in AsyncHttpCall affecting auth.listUsers #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes 2235 The socket code was only introduced to fix a bug in NodeJS 12 (firebase@db8be26) and since then has even needed a patch (firebase@1a34bc4). However the code does not seem necessary at all anymore. Removing this code resolved the described memory leak.
adrianjost
changed the title
adrianjost
changed the title
lahirumaramba
approved these changes
Jul 10, 2023
This was referenced Aug 28, 2024
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2235
The socket code was only introduced to fix a bug in NodeJS 12 (db8be26) and since then has even needed a patch (1a34bc4). However the code does not seem necessary at all anymore. Removing this code resolved the described memory leak.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
If you fixed a bug or added a feature, add a new test to cover your code.Not sure how this could be testedAPI Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.