Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fcm): Increase FCM timeout to 15s #1947

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

lahirumaramba
Copy link
Member

  • Increase the FCM timeout to 15s to match the recommended timeout in the BE. This will prevent duplicate notifications due to the Admin SDK retrying too early.

Fixes: #1900

@chong-shao
Copy link

LGTM. Thanks!

@lahirumaramba lahirumaramba merged commit d551107 into master Oct 20, 2022
@lahirumaramba lahirumaramba deleted the lm-update-timeout branch October 20, 2022 14:49
pragatimodi added a commit that referenced this pull request Oct 21, 2022
* [chore] Release 11.1.0 (#1914)

* feat(auth): Support sms region config change on Tenant and Project level (#1921)

* api proposal sms draft

* support SMS regions config update for project and tenant

* fix lint issues

* remove reCAPTCHA related docs and variable names

* Address PR feedbacks

* removed the unnecessary optional tag

* updated the validation parameter type

* update the doc

* Fixing some problems that failed build 14.x and 16.x

* Undoing package-lock.json changes

* Reverting package-lock.json changes

Co-authored-by: Liubin Jiang <[email protected]>
Co-authored-by: Liubin Jiang <[email protected]>

* build(deps-dev): bump yargs from 17.5.1 to 17.6.0 (#1917)

Bumps [yargs](https://github.com/yargs/yargs) from 17.5.1 to 17.6.0.
- [Release notes](https://github.com/yargs/yargs/releases)
- [Changelog](https://github.com/yargs/yargs/blob/main/CHANGELOG.md)
- [Commits](yargs/yargs@v17.5.1...v17.6.0)

---
updated-dependencies:
- dependency-name: yargs
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump @types/mocha from 9.1.1 to 10.0.0 (#1919)

* build(deps-dev): bump @typescript-eslint/parser from 5.38.1 to 5.40.0 (#1926)

* build(deps-dev): bump @typescript-eslint/eslint-plugin (#1927)

* build(deps): bump @firebase/database-compat from 0.2.6 to 0.2.7 (#1928)

Bumps [@firebase/database-compat](https://github.com/firebase/firebase-js-sdk/tree/HEAD/packages/database-compat) from 0.2.6 to 0.2.7.
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/packages/database-compat/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/commits/@firebase/[email protected]/packages/database-compat)

---
updated-dependencies:
- dependency-name: "@firebase/database-compat"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump minimist from 1.2.6 to 1.2.7 (#1930)

* build(deps): bump jwks-rsa from 2.1.4 to 2.1.5 (#1931)

* build(deps-dev): bump @microsoft/api-extractor from 7.31.2 to 7.33.1 (#1935)

* build(deps-dev): bump bcrypt from 5.0.1 to 5.1.0 (#1934)

* build(deps): bump @firebase/database-types from 0.9.13 to 0.9.16 (#1932)

* build(deps-dev): bump @firebase/app-compat from 0.1.34 to 0.1.37 (#1937)

Bumps [@firebase/app-compat](https://github.com/firebase/firebase-js-sdk/tree/HEAD/packages/app-compat) from 0.1.34 to 0.1.37.
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/packages/app-compat/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/commits/@firebase/[email protected]/packages/app-compat)

---
updated-dependencies:
- dependency-name: "@firebase/app-compat"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @firebase/database-compat from 0.2.7 to 0.2.9 (#1940)

* build(deps-dev): bump @microsoft/api-extractor from 7.33.1 to 7.33.2 (#1939)

* build(deps-dev): bump sinon from 14.0.0 to 14.0.1 (#1938)

* chore(fs): Upgrade firestore dependency (#1941)

Upgrade @google-cloud/firestore dependency to v6.4.0

* [chore] Release 11.2.0 (#1942)

* build(deps-dev): bump @typescript-eslint/eslint-plugin (#1943)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.40.0 to 5.40.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.40.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump mocha from 10.0.0 to 10.1.0 (#1944)

* build(deps-dev): bump @microsoft/api-extractor from 7.33.2 to 7.33.4 (#1946)

Bumps [@microsoft/api-extractor](https://github.com/microsoft/rushstack/tree/HEAD/apps/api-extractor) from 7.33.2 to 7.33.4.
- [Release notes](https://github.com/microsoft/rushstack/releases)
- [Changelog](https://github.com/microsoft/rushstack/blob/main/apps/api-extractor/CHANGELOG.md)
- [Commits](https://github.com/microsoft/rushstack/commits/@microsoft/api-extractor_v7.33.4/apps/api-extractor)

---
updated-dependencies:
- dependency-name: "@microsoft/api-extractor"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(fcm): Increase FCM timeout to 15s (#1947)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Lahiru Maramba <[email protected]>
Co-authored-by: Liubin Jiang <[email protected]>
Co-authored-by: Liubin Jiang <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@thopedam
Copy link

The batch request timeout is not increased. Still duplicate push notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: FCM - Duplicate Topic Notifications
3 participants