Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project config - Recaptcha config #1595

Merged
merged 8 commits into from
Mar 8, 2022
Merged

Conversation

Xiaoshouzi-gh
Copy link
Contributor

Recaptcha config changes in project config.
- Implemented getProjectConfig.
- Implemented updateProjectConfig.
- Updated error code.

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@Xiaoshouzi-gh Xiaoshouzi-gh requested review from lahirumaramba, rsgowman and renkelvin and removed request for rsgowman March 7, 2022 22:41
@Xiaoshouzi-gh Xiaoshouzi-gh changed the title Recaptcha config Project config - Recaptcha config Mar 7, 2022
@@ -57,6 +57,7 @@ export interface UpdateTenantRequest {

/**
* The recaptcha configuration to update on the tenant.
* By enabling reCAPTCHA Enterprise Integration you are agreeing to reCAPTCHA Enterprise Term of Service.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link for the ToS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@@ -122,6 +122,15 @@ export {
TenantManager,
} from './tenant-manager';

export {
UpdateProjectConfigRequest,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expose GetProjectConfigRequest here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a getProjectConfigRequest. It takes an empty object.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Liubin! LGTM!

test/unit/auth/project-config-manager.spec.ts Outdated Show resolved Hide resolved
@Xiaoshouzi-gh Xiaoshouzi-gh merged commit c01f7fb into recaptcha Mar 8, 2022
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the recaptcha-config branch March 9, 2022 00:28
Xiaoshouzi-gh added a commit that referenced this pull request Mar 2, 2023
* Recaptcha config changes in project config.
- Implemented getProjectConfig.
- Implemented updateProjectConfig.
- Updated error code.
- Add Term of Service consents.
Xiaoshouzi-gh added a commit that referenced this pull request Mar 30, 2023
* Recaptcha config changes in project config.
- Implemented getProjectConfig.
- Implemented updateProjectConfig.
- Updated error code.
- Add Term of Service consents.
Xiaoshouzi-gh added a commit that referenced this pull request Apr 11, 2023
* Recaptcha config changes in project config.
- Implemented getProjectConfig.
- Implemented updateProjectConfig.
- Updated error code.
- Add Term of Service consents.
Xiaoshouzi-gh added a commit that referenced this pull request Apr 12, 2023
* Recaptcha config changes in project config.
- Implemented getProjectConfig.
- Implemented updateProjectConfig.
- Updated error code.
- Add Term of Service consents.
Xiaoshouzi-gh added a commit that referenced this pull request Apr 12, 2023
reCAPTCHA support

* Defined reCAPTCHA config. (#1574)
 - Added reCAPTCHA protection states.
 - Added reCAPTCHA action rule.
 - Added reCAPTCHA key config.

* Create/Update tenant with ReCAPTCHA Config (#1586)

* Support reCaptcha config /create update on tenants.
 - Support create and update tenants with reCaptcha config.
 - Added reCaptcha unit tests on tenants operations.

* Project config - Recaptcha config (#1595)

* Recaptcha config changes in project config.
- Implemented getProjectConfig.
- Implemented updateProjectConfig.
- Updated error code.
- Add Term of Service consents.

* Recapcha integ test (#1599)

* Added integ test for Project Config and Tenants update on reCAPTCHA config

* Account defender support for reCAPTCHA (#1616)

* Support use_account_defender add-on feature for reCAPTCHA config.
* Added integration test for account defender feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants