Skip to content

feat: Add support for FIREBASE_STORAGE_EMULATOR_HOST env var #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 8, 2021
Merged

feat: Add support for FIREBASE_STORAGE_EMULATOR_HOST env var #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c74a782
Add support for FIREBASE_STORAGE_EMULATOR_HOST env var
abeisgoat Feb 22, 2021
23f27de
Fixes lint error
abeisgoat Feb 22, 2021
7df63d1
Add test for FIREBASE_STORAGE_EMULATOR_HOST support
ssbushi Mar 11, 2021
bdca9fa
Lint fix
ssbushi Mar 11, 2021
fa27623
Merge branch 'master' into abeisgoat-storage-emulator
ssbushi Mar 11, 2021
9ba17bc
Minor fixes to storage tests
ssbushi Mar 15, 2021
a5d81e9
Merge branch 'master' into abeisgoat-storage-emulator
ssbushi Apr 7, 2021
5c7956b
Address review comments
ssbushi Apr 8, 2021
6db3e79
Address review suggestion
ssbushi Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/storage/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ export class Storage implements StorageInterface {
});
}

if (!process.env.STORAGE_EMULATOR_HOST && process.env.FIREBASE_STORAGE_EMULATOR_HOST) {
process.env.STORAGE_EMULATOR_HOST = process.env.FIREBASE_STORAGE_EMULATOR_HOST;
}

let storage: typeof StorageClient;
try {
storage = require('@google-cloud/storage').Storage;
Expand Down
20 changes: 20 additions & 0 deletions test/unit/storage/storage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,4 +113,24 @@ describe('Storage', () => {
expect(storage.bucket('foo').name).to.equal('foo');
});
});

describe('Emulator mode', () => {
const EMULATOR_HOST = 'http://localhost:9199';

before(() => {
delete process.env.STORAGE_EMULATOR_HOST;
process.env.FIREBASE_STORAGE_EMULATOR_HOST = EMULATOR_HOST;
});

it('sets STORAGE_EMULATOR_HOST if FIREBASE_STORAGE_EMULATOR_HOST is set', () => {
new Storage(mockApp);

expect(process.env.STORAGE_EMULATOR_HOST).to.equal(EMULATOR_HOST);
});

after(() => {
delete process.env.STORAGE_EMULATOR_HOST;
delete process.env.FIREBASE_STORAGE_EMULATOR_HOST;
});
})
});