feat(fcm): Add liveActivityToken to ApnsConfig
#1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new `liveActivityToken` field to the `ApnsConfig` class, allowing you to specify a Live Activity token for APNS messages. The changes include: - Addition of the `liveActivityToken` field in `ApnsConfig.java` and its associated builder. - Updates to unit tests in `MessageTest.java` to verify the correct serialization of the new field and to include it in existing test cases. A new test method `testApnsMessageWithOnlyLiveActivityToken` was added for specific testing. - Update to the integration test in `FirebaseMessagingIT.java` to include the `liveActivityToken` in a test message. An unrelated fix was also included in `MessageTest.java` to correctly use `new BigDecimal(long)` instead of `BigDecimal.valueOf(long)` for `notification_count`.
Corrects the `@Key` annotation for the `liveActivityToken` field in `ApnsConfig.java` from "live-activity-token" to "live_activity_token" to follow snake_case convention for JSON mapping. Unit tests in `MessageTest.java` have been updated to reflect this change in the expected JSON output.
lahirumaramba
assigned
jonathanedey,
egilmorez and
OrlandriaH-G and unassigned
egilmorez
OrlandriaH-G
approved these changes
May 27, 2025
chong-shao
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
liveActivityTokenfield to theApnsConfigclass, allowing you to specify a Live Activity token for APNS messages.The changes include:
liveActivityTokenfield inApnsConfig.javaand its associated builder.MessageTest.javato verify the correct serialization of the new field and to include it in existing test cases. A new test methodtestApnsMessageWithOnlyLiveActivityTokenwas added for specific testing.FirebaseMessagingIT.javato include theliveActivityTokenin a test message.