Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This change implements the accounts:query functionality, providing a new QueryUsers method that allows searching for users with filters and sorting options. It includes full support for tenant-level queries and is accompanied by a suite of unit tests to ensure correctness and prevent regressions.


PR created automatically by Jules for task 3627990016057535938 started by @lahirumaramba

Adds the `QueryUsers` function to the Auth client, allowing users to query for user accounts with various filters.

- Defines `QueryUsersRequest` and `QueryUsersResponse` structs.
- Implements the `QueryUsers` function to call the `accounts:query` endpoint.
- Includes support for tenant-specific queries.
- Adds comprehensive unit tests for the new functionality.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

- Updates the `TestQueryUsersWithTenant` to create a tenant-specific client and verify the request URL.
- Corrects the `QueryUsersRequest` struct to use `string` for `Limit` and `Offset` fields, and adds the `TenantID` field.
- Updates the test cases to reflect the struct changes.
Moves the tenant-specific test for `QueryUsers` to `tenant_mgt_test.go` to follow the existing test structure.

- Renames `TestQueryUsersWithTenant` to `TestTenantQueryUsers`.
- Moves the test function to `auth/tenant_mgt_test.go`.
Renames the `SqlExpression` struct to `SQLExpression` to conform to Go's linting standards for acronyms.

- Updates the struct definition in `auth/user_mgt.go`.
- Updates all usages of the struct in `auth/user_mgt.go` and `auth/user_mgt_test.go`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants