feat(fcm): Support Proxy field in FCM AndroidNotification
#676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
byungwoo-Nam
commented
Mar 7, 2025
byungwoo-Nam
commented
- Adding Proxy Fields to AndroidNotification Struct
Contributor
Author
|
Related issue: #675 |
Contributor
Author
|
Thank you for your interest and request for review |
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Hey @byungwoo-Nam Thank you for your contribution! Could you also add tests to cover the new changes?
lahirumaramba
changed the title
proxy field in FCM AndroidNotification
lahirumaramba
changed the title
proxy field in FCM AndroidNotificationProxy field in FCM AndroidNotification
Member
|
Could you also fix the lint errors? The new types are missing comments/docstrings |
Contributor
Author
|
Thank you for your interest, @lahirumaramba |
Contributor
jonathanedey
left a comment
jonathanedey
left a comment
There was a problem hiding this comment.
Hi @byungwoo-Nam, Added one comment, could you resolve that and fix failing tests. Thanks!
jonathanedey
requested review from
OrlandriaH-G
and removed request for
egilmorez
chong-shao
approved these changes
Mar 18, 2025
OrlandriaH-G
approved these changes
Mar 19, 2025
Contributor
Author
|
Thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.