Fix character-set issues #108
Conversation
…break compatibility with upstream package
|
I guess this is the PR you cancelled due to conflicts. You ok with re-opening this? |
|
Yup, there you go :). |
|
@digitalsparky thx for the PR. Works fine for non-UTF8 wsdls like https://www.demo.ilias.de/webservice/soap/server.php?wsdl @fiorix any ETA when this gets merged. I built it locally atm |
|
Pull request updated so you can easily merge into upstream (reverts forked namespace changes) |
|
ping @fiorix |
|
note: needs to built with GO111MODULE=on env var |
|
CI still failing. Please fix the tests and I'll be happy to merge. |
|
Still failing on Go 1.9 for obvious reasons. Gotta drop older versions and leave Go 1.11 and tip. |
|
Fixed, was using go mod but that's not supported in go 1.9, changed to dep. |
|
Recommend changing to go mod once you deprecate 1.9 support. |
|
👍 I squashed your commits and merged. |
|
Thanks, have a great day! |
* Fix character-set issues * Add decoder charset compliance to soap client * Update travis ci file to force env var for build and path to golint
* Fix character-set issues * Add decoder charset compliance to soap client * Update travis ci file to force env var for build and path to golint
Hi there, I was playing around with your tool, however, it crashes out when there is a character set other than UTF-8.
This patch resolves that issue.
I've included the package dependencies using 'dep' (gopkg lock files included).