Input Box Support for User Settings + Panel Tests #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
heswell
reviewed
Jul 4, 2024
| @@ -152,7 +153,7 @@ export type SettingsFormProps = SettingsProps & HTMLAttributes<HTMLDivElement>; | |||
| export const SettingsForm = ({ | |||
| settingsSchema: applicationSettingsSchema, | |||
There was a problem hiding this comment.
no need to rename any of these props,. just refer to them in the code as-is, so
export const SettingsForm = ({
settings,
settingsSchema,
onSettingChanged,
...htmlAttributes
})
heswell
reviewed
Jul 4, 2024
| const inputHandler = useCallback<FormEventHandler>( | ||
| (event) => { | ||
| const fieldName = getFieldNameFromEventTarget(event); | ||
| const { value } = event.target as HTMLInputElement; |
There was a problem hiding this comment.
this will always be a string. WIll need to convert to a numeric, if that is what the property represents
rohinp14
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input box change handler and validation logic for user settings form
Component cypress tests for user settings panel
Add tooltip for user prompts when validation fails