Adjust setup.py for MacOS wheel dist #778

sc1f · 2019-10-21T14:35:05Z

This PR allows us to build a portable wheel distribution for OSX:

Our binaries depend on @rpath, which is set relative to the build location of the binary. This causes a problem when distributing to PyPi/installing from pip. In setup.py, we adjust the install names of the built binary to reference @loader_path, i.e. relative to the actual location of the binary download.
Pin pyarrow in our requirements. This means that TBB is the only system requirement that needs to be installed from brew/build from source.
Fix bumpversion config
Fix manifest - graft source files and not tests

timkpaine · 2019-10-21T20:44:17Z

looks good!

texodus · 2019-10-22T01:15:29Z

Thanks for the PR!

finos-admin added the cla-present label Oct 21, 2019

timkpaine added enhancement Feature requests or improvements Python labels Oct 21, 2019

sc1f added 2 commits October 21, 2019 15:39

Build wheel for OSX

282ee34

set @rpath in cmake

11e68b9

sc1f force-pushed the wheel branch from d750f07 to 11e68b9 Compare October 21, 2019 19:39

texodus merged commit 56b9064 into master Oct 22, 2019

texodus deleted the wheel branch October 22, 2019 01:15

texodus added internal Internal refactoring and code quality improvement and removed enhancement Feature requests or improvements labels Jan 3, 2020

Provide feedback